Refactor Core Documentation (README, SYNTAX, GLR) and Sync API Signatures#52
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive updates to the documentation and guidelines of RustyLR, including a new agent guidelines file, a rewritten GLR parsing guide, an updated main README, and a restructured syntax reference. The review feedback highlights several issues in the documentation examples, such as unbound variables in the GLR expression grammar, absolute local file URLs in the agent guidelines, misleading comments regarding token value extraction, and a missing return type in the userdata example.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| ## 2. Documenting Syntax Modifications | ||
| In particular, when new grammar rules, directives, pattern operators, or reduce action features are introduced: | ||
| - You must add a detailed explanation with examples inside [SYNTAX.md](file:///wsl.localhost/Ubuntu-22.04/home/ehwan/workspace/RustyLR/SYNTAX.md). |
There was a problem hiding this comment.
The link to SYNTAX.md uses an absolute local file URL (file:///wsl.localhost/...) pointing to your local WSL environment. This should be a relative link so that it works for other users and in different environments.
| - You must add a detailed explanation with examples inside [SYNTAX.md](file:///wsl.localhost/Ubuntu-22.04/home/ehwan/workspace/RustyLR/SYNTAX.md). | |
| - You must add a detailed explanation with examples inside [SYNTAX.md](../SYNTAX.md). |
| In particular, when new grammar rules, directives, pattern operators, or reduce action features are introduced: | ||
| - You must add a detailed explanation with examples inside [SYNTAX.md](file:///wsl.localhost/Ubuntu-22.04/home/ehwan/workspace/RustyLR/SYNTAX.md). | ||
| - Ensure the documentation style matches the formatting, tone, and organization of existing syntax references. | ||
| - Preserve the exact header anchor names that are referenced as diagnostic URLs within the codebase (e.g., in [parser.rs](file:///wsl.localhost/Ubuntu-22.04/home/ehwan/workspace/RustyLR/rusty_lr_parser/src/parser/parser.rs)). |
There was a problem hiding this comment.
The link to parser.rs uses an absolute local file URL pointing to your local WSL environment. This should be a relative link so that it works for other users and in different environments.
| - Preserve the exact header anchor names that are referenced as diagnostic URLs within the codebase (e.g., in [parser.rs](file:///wsl.localhost/Ubuntu-22.04/home/ehwan/workspace/RustyLR/rusty_lr_parser/src/parser/parser.rs)). | |
| - Preserve the exact header anchor names that are referenced as diagnostic URLs within the codebase (e.g., in [parser.rs](../rusty_lr_parser/src/parser/parser.rs)). |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This Pull Request refactors the project's markdown documentation files (
README.md,SYNTAX.md, andGLR.md) to improve readability, translate all parts into clean, natural English, and update all code examples to reflect the actual API signatures defined inrusty_lr_core. It also establishes workspace guidelines for AI agents in.agents/AGENTS.md.Proposed Changes
Documentation Refactoring
README.md:accept,expected_token,can_feed,trace,backtrace) to include the required&parserand&mut userdataarguments.SYNTAX.md:rusty_lr_parser/src/parser/parser.rs(e.g.,#token-type-must-defined,#operator-precedence,#location-tracking).*,+,?,$sep()), groupings, and rule prioritization.GLR.md:&mut userdataparameter.feed_locationand dynamic branch pruning methods (Errpropagation and*shift = false).Project Customization Rules
.agents/AGENTS.md(New):Verification