Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the logic in the expected() method for both deterministic and nondeterministic parser contexts. The fix addresses how the parser handles state stack operations when determining expected tokens.
- Refactored
expected_token_implto use a separateextra_state_stackinstead of modifying the original state stack - Updated parameter handling to properly track stack lengths and node positions
- Implemented recursive token expectation logic that correctly handles reduce operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rusty_lr_core/src/parser/nondeterministic/context.rs | Updated expected token implementation to use node-based stack tracking with proper reduce operation handling |
| rusty_lr_core/src/parser/deterministic/context.rs | Refactored to use separate extra state stack and stack length tracking for cleaner state management |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.