Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the can_feed() logic by refactoring the implementation to handle stack operations more accurately. The changes improve the parser's ability to determine whether it can accept a given terminal symbol by properly managing state and precedence stacks during lookahead operations.
Key changes include:
- Refactored
can_feed_implto use separate extra stacks instead of cloning existing stacks - Added proper handling of reduce operations in nondeterministic parsing with multiple reduction paths
- Improved stack length tracking and precedence calculation logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| rusty_lr_core/src/parser/nondeterministic/context.rs | Major refactoring of can_feed_impl to handle multiple reduce paths and use extra stacks for simulation |
| rusty_lr_core/src/parser/deterministic/context.rs | Updated can_feed_impl to use extra stacks and improved stack length tracking |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.