Removed %runtime directive#26
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated %runtime directive functionality from the RustyLR parser generator. The directive previously allowed switching between compile-time and runtime table generation, but this feature has been removed entirely.
- Removed all references to the
%runtimedirective from lexer, parser, and grammar structures - Simplified state type definitions by removing generic parameters for state and rule indices
- Updated bootstrap tests to remove runtime configuration options
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/bootstrap_test.sh | Simplified test configurations by removing --runtime flag combinations |
| rusty_lr_parser/src/parser/parser.rs | Removed %runtime and %eofdef token definitions and directive handling |
| rusty_lr_parser/src/parser/lexer.rs | Removed Runtime and EofDef lexed token variants |
| rusty_lr_parser/src/parser/args.rs | Removed compiled field from GrammarArgs struct |
| rusty_lr_parser/src/grammar.rs | Removed compiled field and simplified state type parameters |
| rusty_lr_parser/src/emit.rs | Removed runtime table generation code path |
| rusty_lr_executable/src/main.rs | Removed runtime flag handling |
| rusty_lr_executable/src/arg.rs | Removed --runtime command line argument |
| rusty_lr_core/src/builder/state.rs | Simplified State struct to remove generic type parameters |
| rusty_lr_core/src/builder/mod.rs | Updated States struct to use simplified state type |
| rusty_lr_core/src/builder/grammar.rs | Updated function signatures to use simplified state type |
| rusty_lr_buildscript/src/lib.rs | Removed runtime configuration from builder |
| SYNTAX.md | Removed documentation for %runtime directive |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.