Skip to content

Removed %runtime directive#26

Merged
ehwan merged 8 commits into
mainfrom
remove_runtime
Aug 22, 2025
Merged

Removed %runtime directive#26
ehwan merged 8 commits into
mainfrom
remove_runtime

Conversation

@ehwan

@ehwan ehwan commented Aug 22, 2025

Copy link
Copy Markdown
Owner

No description provided.

@ehwan
ehwan requested a review from Copilot August 22, 2025 11:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated %runtime directive functionality from the RustyLR parser generator. The directive previously allowed switching between compile-time and runtime table generation, but this feature has been removed entirely.

  • Removed all references to the %runtime directive from lexer, parser, and grammar structures
  • Simplified state type definitions by removing generic parameters for state and rule indices
  • Updated bootstrap tests to remove runtime configuration options

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
scripts/bootstrap_test.sh Simplified test configurations by removing --runtime flag combinations
rusty_lr_parser/src/parser/parser.rs Removed %runtime and %eofdef token definitions and directive handling
rusty_lr_parser/src/parser/lexer.rs Removed Runtime and EofDef lexed token variants
rusty_lr_parser/src/parser/args.rs Removed compiled field from GrammarArgs struct
rusty_lr_parser/src/grammar.rs Removed compiled field and simplified state type parameters
rusty_lr_parser/src/emit.rs Removed runtime table generation code path
rusty_lr_executable/src/main.rs Removed runtime flag handling
rusty_lr_executable/src/arg.rs Removed --runtime command line argument
rusty_lr_core/src/builder/state.rs Simplified State struct to remove generic type parameters
rusty_lr_core/src/builder/mod.rs Updated States struct to use simplified state type
rusty_lr_core/src/builder/grammar.rs Updated function signatures to use simplified state type
rusty_lr_buildscript/src/lib.rs Removed runtime configuration from builder
SYNTAX.md Removed documentation for %runtime directive

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ehwan
ehwan merged commit 9527a2e into main Aug 22, 2025
1 check passed
@ehwan
ehwan deleted the remove_runtime branch August 22, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants