fix command line arguments for note diagnostics#19
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the command line argument handling for note diagnostics by changing from positive verbose flags to negative no-flag options and updating the underlying builder methods to accept boolean values instead of just enabling options.
- Replaced verbose flags with no-flags (e.g.,
--verbose-conflictbecomes--no-conflict) - Updated builder methods to accept boolean parameters for more flexible control
- Improved documentation strings with better capitalization and clarity
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| rusty_lr_executable/src/main.rs | Updated to use new no-flag arguments and boolean builder methods |
| rusty_lr_executable/src/arg.rs | Renamed verbose flags to no-flags and improved documentation |
| rusty_lr_buildscript/src/lib.rs | Refactored builder methods to accept boolean values and renamed internal fields |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.