Switch to the ImageDescriptor in EntryInfo instead of Image.#497
Merged
ptziegler merged 1 commit intoJul 2, 2023
Merged
Conversation
Contributor
Author
ptziegler
force-pushed
the
use-imagedescriptor-for-entryinfo
branch
2 times, most recently
from
ffc5c57 to
64f1da4
Compare
Similar to IEntry, we shouldn't use Images directly inside the data model, due to having to explicitly dispose them, once they are no longer needed. This problem doesn't exist when using ImageDescriptors instead. Where necessary, image instances are created via a resource manager. In order to remain compatible with the old image-based API, images are converted into descriptors via ImageDescriptor.createFromImage()
ptziegler
force-pushed
the
use-imagedescriptor-for-entryinfo
branch
from
64f1da4 to
399466f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to IEntry, we shouldn't use Images directly inside the data model, due to having to explicitly dispose them, once they are no longer needed. This problem doesn't exist when using ImageDescriptors instead. Where necessary, image instances are created via a resource manager. In order to remain compatible with the old image-based API, images are converted into descriptors via ImageDescriptor.createFromImage()