Skip to content

Perform automatic code cleanup in all source files - Correct indentation#495

Merged
ptziegler merged 1 commit into
eclipse-windowbuilder:masterfrom
ptziegler:tabs-instead-of-spaces
Jun 30, 2023
Merged

Perform automatic code cleanup in all source files - Correct indentation#495
ptziegler merged 1 commit into
eclipse-windowbuilder:masterfrom
ptziegler:tabs-instead-of-spaces

Conversation

@ptziegler

@ptziegler ptziegler commented Jun 29, 2023

Copy link
Copy Markdown
Contributor

Perform automatic code cleanup in all source files - Correct indentation
Every 2 spaces are replaced by a tabulator character, in order to become
compatible with the built-in Eclipse profile.

Given the high risk of breaking the format when doing an automatic
cleanup, only the indentation is adjusted (excluding e.g. switching to
diamond operators). This should ensure that without whitespaces changes,
the code remains identical.

One can disable whitespace changes in the Git diff view, meaning this
commit should permanently overshadow any earlier changes.

Given the size of this change (600000+ lines are changed) a review is
impossible.

@ptziegler

Copy link
Copy Markdown
Contributor Author

#375

@ptziegler

Copy link
Copy Markdown
Contributor Author

Over half a million lines of code are affected... yikes

@ptziegler ptziegler linked an issue Jun 29, 2023 that may be closed by this pull request
@github-actions

github-actions Bot commented Jun 29, 2023

Copy link
Copy Markdown

Unit Test Results

       16 files         16 suites   56m 4s ⏱️
  7 214 tests   7 214 ✔️ 0 💤 0
14 436 runs  14 436 ✔️ 0 💤 0

Results for commit 1b8ece7.

♻️ This comment has been updated with latest results.

Every 2 spaces are replaced by a tabulator character, in order to become
compatible with the built-in Eclipse profile.

Given the high risk of breaking the format when doing an automatic
cleanup, only the indentation is adjusted (excluding e.g. switching to
diamond operators). This should ensure that without whitespaces changes,
the code remains identical.

One can disable whitespace changes in the Git diff view, meaning this
commit should permanently overshadow any earlier changes.

Given the size of this change (600000+ lines are changed) a review is
impossible.
@ptziegler ptziegler force-pushed the tabs-instead-of-spaces branch from 5d7d143 to 1b8ece7 Compare June 30, 2023 17:11
@ptziegler ptziegler changed the title Perform automatic code cleanup - Correct indentation Perform automatic code cleanup in all source files - Correct indentation Jun 30, 2023
@ptziegler ptziegler merged commit 47146a0 into eclipse-windowbuilder:master Jun 30, 2023
@ptziegler ptziegler deleted the tabs-instead-of-spaces branch August 12, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent formatter settings in WB projects

1 participant