Skip to content

Set Layouts via Preference Page#182

Merged
MarcelduPreez merged 1 commit into
eclipse-windowbuilder:masterfrom
MarcelduPreez:Hide_Layouts_Via_Preference_page
Jul 11, 2022
Merged

Set Layouts via Preference Page#182
MarcelduPreez merged 1 commit into
eclipse-windowbuilder:masterfrom
MarcelduPreez:Hide_Layouts_Via_Preference_page

Conversation

@MarcelduPreez

Copy link
Copy Markdown
Contributor

This closes issue #181

Users are now able to set the specific layouts they want to be made available in Windowbuilder. By default all layouts are available.
Following is a screenshot of the preference page in Swing:
image
Following is a screenshot of the preference page in SWT:
image

Below the preferences are set to only include the border layout, the UI changes can be seen in the layout group on the designer palette as well as in the context menu and layout dropwdown in the Properties view.
image

image
image

@vogella

vogella commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

@MarcelS4 new preference UI looks really good but I think you forgot to consider the new preferences for the SWT case.

image

image

Can you check and update the review?

@vogella vogella self-requested a review April 21, 2022 09:45

@vogella vogella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SWT use case is currently not considered

@wimjongman wimjongman linked an issue Apr 21, 2022 that may be closed by this pull request
@wimjongman wimjongman added this to the 1.10.0 milestone Apr 21, 2022
@vogella

vogella commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

please rebase onto latest master in the origin

@MarcelduPreez MarcelduPreez force-pushed the Hide_Layouts_Via_Preference_page branch from 21b4b09 to 423c5b1 Compare May 3, 2022 06:02
@vogella

vogella commented May 3, 2022

Copy link
Copy Markdown
Contributor

@MarcelS4 did you fix the SWT use case?

@MarcelduPreez

Copy link
Copy Markdown
Contributor Author

Yes, the SWT use case should now work like the swing use case

@wimjongman

Copy link
Copy Markdown
Contributor

Congratulations on your committer election, @MarcelS4! 🎉

@vogella

vogella commented May 3, 2022

Copy link
Copy Markdown
Contributor

Thanks, Marcel, testing it now!

@MarcelduPreez MarcelduPreez requested a review from vogella May 17, 2022 07:19
@MarcelduPreez MarcelduPreez force-pushed the Hide_Layouts_Via_Preference_page branch from e11ab33 to 27374a7 Compare May 17, 2022 09:23
@vogella

vogella commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Please combine both commits

@MarcelduPreez

Copy link
Copy Markdown
Contributor Author

@vogella Some WB tests fail (that didnt fail before), specifically in the SWT test suite. I've tested these on other branches as well, branches that we know they worked on. Any idea what could've caused this?

It occurs in:

  • org.eclipse.wb.tests.designer.swt.model.property.ResourceManagerTest
  • org.eclipse.wb.tests.designer.swt.model.property.SWTResrouceManagerTest
  • org.eclipse.wb.tests.designer.swt.model.property.SWTResourceManagerTest

The errors that occur are:

  • Java Model Exception: Error in Java Model (code 977): /TestProject/src/test/Test.java already exists in target
  • java.lang.ClassNotFoundException: org.eclipse.wb.swt.SWTResourceManager

I recall you mentioning you had issues with your SWT tests, do these issues look familiar to you?

@vogella

vogella commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

@MarcelS4 I had seem them also but only if I used Eclipse during the test run. Can this also be the case for you?

@MarcelduPreez

Copy link
Copy Markdown
Contributor Author

I didnt use eclipse during the testing but I did use my computer at the time of the tests. I'll try running them without touching my system and see if that does the trick.

@MarcelduPreez

Copy link
Copy Markdown
Contributor Author

I've run the tests and didnt touch anything during the test runs but still no luck

@vogella

vogella commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

IIRC I had this during the review of one of the library changes. If you revert both library changes do you still get the error?

@MarcelduPreez MarcelduPreez force-pushed the Hide_Layouts_Via_Preference_page branch 2 times, most recently from 8ac01c6 to da51b95 Compare June 21, 2022 13:17
@MarcelduPreez MarcelduPreez force-pushed the Hide_Layouts_Via_Preference_page branch from da51b95 to 76b2d38 Compare July 5, 2022 13:29
@github-actions

github-actions Bot commented Jul 5, 2022

Copy link
Copy Markdown

Unit Test Results

    4 files      4 suites   1m 11s ⏱️
  77 tests   77 ✔️ 0 💤 0
166 runs  166 ✔️ 0 💤 0

Results for commit f4616f3.

♻️ This comment has been updated with latest results.

@vogella

vogella commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

Can you check LayoutManagersTest#test_customImplementationOf_LayoutManager? This test fails with this change and looks related.

Users can now specify which layouts (SWT and Swing) should be available
for use via a layouts preference page.

Filters the design palette for SWT design page as well
@MarcelduPreez MarcelduPreez force-pushed the Hide_Layouts_Via_Preference_page branch from 76b2d38 to f4616f3 Compare July 11, 2022 13:25
@MarcelduPreez MarcelduPreez merged commit 280f8aa into eclipse-windowbuilder:master Jul 11, 2022
@wimjongman wimjongman linked an issue Aug 31, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set availability of certain Layouts Windowbuilder Basic UI Layouts

3 participants