Rewrite GTK3 screenshot logic to work with Wayland #633#1534
Open
ptziegler wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Test Results 4 files ± 0 4 suites ±0 1h 38m 49s ⏱️ - 48m 11s For more details on these errors, see this check. Results for commit ce23e0f. ± Comparison against base commit b013371. ♻️ This comment has been updated with latest results. |
…der#633 For the longest time, screenshots on Linux were done by capturing parts of the window where a given widget was located. This approach is inherently incompatible with constraints imposed by Wayland, resulting in a blank preview. Instead of working on the window, we directly work on the widget (similar to the SWT implementation). This approach requires the widget to be fully rendered. Note that this new implementation is only available with Java 24 or higher. Closes eclipse-windowbuilder#633
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the longest time, screenshots on Linux were done by capturing parts of the window where a given widget was located. This approach is inherently incompatible with constraints imposed by Wayland, resulting in a blank preview.
Instead of working on the window, we directly work on the widget (similar to the SWT implementation). This approach requires the widget to be fully rendered.
Note that this new implementation is only available with Java 24 or higher.
Closes #633