chore: simplify show action and remove stale queue param#19
Merged
Conversation
Associations are already eager-loaded via includes in the show action. The view now reads @job.failed_execution and @job.blocked_execution directly — no extra queries, no extra variables. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Queue is no longer set in JobsController#index after the Queues::JobsController refactor. The nil was harmless but dead code. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 187 185 -2
=========================================
- Hits 187 185 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@failed_executionand@blocked_executioncontroller assigns inJobsController#show— associations are already eager-loaded viaincludes, so the view reads@job.failed_executionand@job.blocked_executiondirectly at no extra query costqueue: @queuefrom the status tab links injobs/index.html.erb—@queueis no longer set inJobsController#indexafter theQueues::JobsControllerrefactor; thenilwas harmless but dead codeTest plan
bundle exec rspec spec/requests/solid_queue_web/jobs_spec.rb)bin/rubocop)🤖 Generated with Claude Code