Open
Conversation
AndrewSazonov
added
the
[scope] maintenance
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #149 +/- ##
==========================================
Coverage ? 97.84%
==========================================
Files ? 38
Lines ? 2599
Branches ? 449
==========================================
Hits ? 2543
Misses ? 32
Partials ? 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
henrikjacobsenfys
approved these changes
Apr 2, 2026
Member
henrikjacobsenfys
left a comment
henrikjacobsenfys
left a comment
There was a problem hiding this comment.
A small nitpick, but otherwise looks good to me :)
| energy_offset : Numeric | Parameter, default=0.0 | ||
| An energy offset to apply to the energy values before convolution. By default, 0.0. | ||
| upsample_factor : Numeric | None, default=5 | ||
| The factor by which to upsample the input data before convolution. Default is |
Member
There was a problem hiding this comment.
This and many other places has default in the type description, and I also had it in the text description (I thought I had gotten rid of those, but clearly not). But now it says "Default is 5. By default, 5".
I don't mind too much as it's all still work in progress, but it doesn't look great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies the latest Copier template updates and converts all docstrings in the source tree from Google style to NumPy style. Tutorial for Magnetic nanoparticles is added to TOC.