Changed add_vertex behaviour on identical unique name#137
Closed
Changed add_vertex behaviour on identical unique name#137
Conversation
Member
|
It seems like this risks renaming unique names which may be problematic for dependent Parameters? I.e. imagine I've made a Parameter a somewhere: And then later (perhaps in a different file) want to make a Parameter c which depends on b Previously, this would throw an error, and I would know that I had messed up. Now it changes the unique name of b to |
Member
Author
|
I'll close this PR as it got overriden by the proper fix in #175 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We throw on creating a new map vertex if the parameter has the same unique name.
This makes sense when a typical job is being run.
However, in a multiprocessing environment, we can't guarantee this behaviour, especially considering the
global_objectis a singleton and will be the same across the CPU pool.One solution would be to allow multiple copies of
global_objectin MPI, but this seems a complex and error prone (at least at the moment). The alternative is to modify the unique name if it clashes with one in the map.This is what I am proposing here.