Skip to content

ppc64le: Fix wrong offset for destination symbols in create_klp_relasecs_and_syms() #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kamalesh-babulal wants to merge 1 commit into from
Closed

ppc64le: Fix wrong offset for destination symbols in create_klp_relasecs_and_syms() #754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions kpatch-build/create-klp-module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,19 @@ static void create_klp_relasecs_and_syms(struct kpatch_elf *kelf, struct section
ALLOC_LINK(rela, &klp_relasec->relas);
rela->sym = sym;
rela->type = krelas[index].type;
if (!strcmp(dest->sec->name, ".toc"))
if (!strcmp(dest->sec->name, ".toc")) {
rela->offset = toc_offset;
else
} else {
rela->offset = krelas[index].offset + dest->sym.st_value;
/*
* With GCC 6+ every local function symbol has the value of 0x8.
* If the destination sym is local function, don't add the
* sym value to the offset.
*/
if (dest->sym.st_value &&
dest->type == STT_FUNC && dest->bind == STB_LOCAL)
rela->offset -= 8;
}

/*
* GCC 6+ adds 0x8 to the offset of every local function entry
Expand Down