Steps to reproduce
- Create an AWS gateway with ACM certificate
type: gateway
name: test-aws-private-gateway
backend: aws
region: eu-central-1
domain: '...'
public_ip: False
certificate:
type: acm
arn: '...'
- Run a service with
https: true. You'll see CLI and UI displaying service URL starting with http://
Actual behaviour
The issue is that dstack chooses http for gateways with ACM certificates because it needs to send https=False to gateway to avoid configuring https on nginx:
|
if configuration.certificate is not None and configuration.certificate.type == "acm": |
|
return False |
But the same logic is used for displaying service URL.
Expected behaviour
The must be separate logic for choosing https/http for display and gateway configuration.
dstack version
master
Server logs
Additional information
No response
Steps to reproduce
https: true. You'll see CLI and UI displaying service URL starting with http://Actual behaviour
The issue is that dstack chooses http for gateways with ACM certificates because it needs to send https=False to gateway to avoid configuring https on nginx:
dstack/src/dstack/_internal/server/services/services/__init__.py
Lines 448 to 449 in 30e90d3
But the same logic is used for displaying service URL.
Expected behaviour
The must be separate logic for choosing https/http for display and gateway configuration.
dstack version
master
Server logs
Additional information
No response