Fix doc generation and PyPI uploads by pinning to Python 3.7#500
Merged
maxbelanger merged 4 commits intomainfrom May 14, 2024
Merged
Fix doc generation and PyPI uploads by pinning to Python 3.7#500maxbelanger merged 4 commits intomainfrom
maxbelanger merged 4 commits intomainfrom
Conversation
maxbelanger
commented
May 13, 2024
| build: | ||
| os: ubuntu-20.04 | ||
| tools: | ||
| python: "3.7" |
Contributor
Author
There was a problem hiding this comment.
This now matches what we actually run to test that we can generate docs in the CI workflow.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
=======================================
Coverage 64.26% 64.26%
=======================================
Files 31 31
Lines 53579 53579
Branches 3905 3905
=======================================
Hits 34430 34430
Misses 18989 18989
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sderickson
approved these changes
May 14, 2024
f5a3fe0 to
ab1f7c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version 2config file. In it, we pin the version used to generate the docs to Python 3.7, which matches what is currently tested (and green) in CI.