Update signatures of loads and parse to include return types#108
Merged
dpranke merged 3 commits intodpranke:mainfrom Apr 7, 2026
Merged
Update signatures of loads and parse to include return types#108dpranke merged 3 commits intodpranke:mainfrom
loads and parse to include return types#108dpranke merged 3 commits intodpranke:mainfrom
Conversation
Owner
|
Thanks for the fix! I admit I'm a bit surprised that I hadn't already done (or caught this), so it's appreciated. One thing, though: the package still supports 3.9, so I don't think you can use |
Contributor
Author
|
Sure. Done |
Owner
|
Argh, sorry, that needs to be |
Contributor
Author
|
I'll do it myself |
Contributor
Author
|
While I'm at it, should I type the helper functions as well? ( |
Owner
|
Sure, feel free to add types to anything in lib.py that is missing them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107.