Properly ingest dotnetup data after data-x-migration#54051
Merged
nagilson merged 78 commits intoMay 12, 2026
Merged
Conversation
very wip code, but: spans don't get consumed by the data-x-platform only events which go into the 'traces' table so we need to send this data as a 'trace' (event) but also still have the spans so we can use the aspire like dashboards I believe duration and other span properties dont get added to the activities so we need to add them ourselves.
… and activity also add test failing if the code tries settag
we observe spotty behavior by running at scale in ci for now!
nagilson
commented
Apr 22, 2026
nagilson
commented
Apr 22, 2026
nagilson
commented
Apr 23, 2026
…ike download + commands
…hub.com/nagilson/sdk into nagilson-dnup-otel-migration-for-data-x
we need the acitvity to stop to get the time and properly dispose of it and the span but activity.current fails for root activities and returns null causing command spans and events to never get published. we consolidate the timing and other metadata ingestion into the event sinto 1 place here.
…hub.com/nagilson/sdk into nagilson-dnup-otel-migration-for-data-x
…hub.com/nagilson/sdk into nagilson-dnup-otel-migration-for-data-x
nagilson
requested review from
dsplaisted
and removed request for
a team and
dsplaisted
…nstallation -> D:\a\_work\1\s\artifacts\bin\Microsoft.Dotnet.Installation\Debug\net11.0\Microsoft.Dotnet.Installation.dll D:\a\_work\1\s\src\Installer\dotnetup\Telemetry\TelemetryCommonProperties.cs(4,1): error IDE0005: Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005) [D:\a\_work\1\s\src\Installer\dotnetup\dotnetup.csproj] Build FAILED. D:\a\_work\1\s\src\Installer\dotnetup\Telemetry\TelemetryCommonProperties.cs(4,1): error IDE0005: Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005) [D:\a\_work\1\s\src\Installer\dotnetup\dotnetup.csproj] 0 Warning(s) 1 Error(s) Time Elapsed 00:00:06.72 Microsoft.Dotnet.Installation -> D:\a\_work\1\s\artifacts\bin\Microsoft.Dotnet.Installation\Debug\net11.0\Microsoft.Dotnet.Installation.dll D:\a\_work\1\s\src\Installer\dotnetup\Telemetry\TelemetryCommonProperties.cs(4,1): error IDE0005: Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005) [D:\a\_work\1\s\src\Installer\dotnetup\dotnetup.csproj] Build FAILED. D:\a\_work\1\s\src\Installer\dotnetup\Telemetry\TelemetryCommonProperties.cs(4,1): error IDE0005: Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005) [D:\a\_work\1\s\src\Installer\dotnetup\dotnetup.csproj] 0 Warning(s) 1 Error(s)
…hub.com/nagilson/sdk into nagilson-dnup-otel-migration-for-data-x
dsplaisted
approved these changes
May 6, 2026
…ent name We can derive the parent activity name from the event name if we follow the / pattern - note this makes it so we cant use / in telemetry event names
…t exception types.
for clarity - invocation may tehcnically be standard but this matches the 'command' patterns
…lls + update 'root' dependents
Member
Author
|
known issues in the SDK repo |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #52785
The new
dotnetupdashboard added by this PR can be viewed under VPN + Authentication on https://dataexplorer.azure.com/dashboards/cbf42ddd-1ef6-415d-b64d-e6f4d15bcaa8Samples:
History:
#52792 added working telemetry with an app insights board to
dotnetupbut used a separate implementation as the SDK did not use otel (not native aot)#53343 moved to the official key which broke and made all data get lost (intentional)
#53181 implemented OpenTelemetry usage within the .NET SDK.
This PR:
Follow Up:
#54165 merge sdk code changes into sdk main