Skip to content

[main] Source code updates from dotnet/dotnet#51143

Merged
jaredpar merged 8 commits into
mainfrom
darc-main-0a5ff37f-65a6-40ce-93fd-0f4730439acc
Oct 15, 2025
Merged

[main] Source code updates from dotnet/dotnet#51143
jaredpar merged 8 commits into
mainfrom
darc-main-0a5ff37f-65a6-40ce-93fd-0f4730439acc

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

  • From 10.0.0-rc.1.25479.108 to 10.0.0-rc.1.25508.102
    • dotnet-dev-certs
    • dotnet-user-jwts
    • dotnet-user-secrets
    • Microsoft.AspNetCore.Analyzers
    • Microsoft.AspNetCore.App.Ref
    • Microsoft.AspNetCore.App.Ref.Internal
    • Microsoft.AspNetCore.Authentication.Facebook
    • Microsoft.AspNetCore.Authentication.Google
    • Microsoft.AspNetCore.Authentication.MicrosoftAccount
    • Microsoft.AspNetCore.Authorization
    • Microsoft.AspNetCore.Components
    • Microsoft.AspNetCore.Components.Analyzers
    • Microsoft.AspNetCore.Components.Forms
    • Microsoft.AspNetCore.Components.SdkAnalyzers
    • Microsoft.AspNetCore.Components.Web
    • Microsoft.AspNetCore.Components.WebAssembly
    • Microsoft.AspNetCore.Components.WebAssembly.Server
    • Microsoft.AspNetCore.Components.WebView
    • Microsoft.AspNetCore.DeveloperCertificates.XPlat
    • Microsoft.AspNetCore.Metadata
    • Microsoft.AspNetCore.Mvc.Analyzers
    • Microsoft.AspNetCore.Mvc.Api.Analyzers
    • Microsoft.AspNetCore.TestHost
    • Microsoft.Bcl.AsyncInterfaces
    • Microsoft.DotNet.Web.ItemTemplates.10.0
    • Microsoft.DotNet.Web.ProjectTemplates.10.0
    • Microsoft.Extensions.Configuration.Ini
    • Microsoft.Extensions.DependencyModel
    • Microsoft.Extensions.FileProviders.Abstractions
    • Microsoft.Extensions.FileProviders.Embedded
    • Microsoft.Extensions.FileSystemGlobbing
    • Microsoft.Extensions.Logging
    • Microsoft.Extensions.Logging.Abstractions
    • Microsoft.Extensions.Logging.Console
    • Microsoft.Extensions.ObjectPool
    • Microsoft.JSInterop
    • Microsoft.NET.HostModel
    • Microsoft.NET.ILLink.Tasks
    • Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.win-x64
    • Microsoft.NET.Sdk.WindowsDesktop
    • Microsoft.NETCore.App.Ref
    • Microsoft.NETCore.Platforms
    • Microsoft.Win32.SystemEvents
    • Microsoft.WindowsDesktop.App.Internal
    • Microsoft.WindowsDesktop.App.Ref
    • System.CodeDom
    • System.ComponentModel.Composition
    • System.Composition.AttributedModel
    • System.Composition.Convention
    • System.Composition.Hosting
    • System.Composition.Runtime
    • System.Composition.TypedParts
    • System.Configuration.ConfigurationManager
    • System.Diagnostics.DiagnosticSource
    • System.Formats.Asn1
    • System.IO.Hashing
    • System.Reflection.MetadataLoadContext
    • System.Resources.Extensions
    • System.Security.Cryptography.Pkcs
    • System.Security.Cryptography.ProtectedData
    • System.Security.Cryptography.Xml
    • System.Security.Permissions
    • System.ServiceProcess.ServiceController
    • System.Text.Encoding.CodePages
    • System.Text.Json
    • System.Windows.Extensions
  • From 10.0.0-preview.25479.108 to 10.0.0-preview.25508.102
    • Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal
    • Microsoft.CodeAnalysis.Razor.Tooling.Internal
    • Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
  • From 18.0.0-preview-25479-108 to 18.1.0-preview-25508-102
    • Microsoft.Build
    • Microsoft.Build.Localization
    • Microsoft.NET.Test.Sdk
    • Microsoft.TestPlatform.Build
    • Microsoft.TestPlatform.CLI
  • From 7.0.0-preview.1.48008 to 7.0.0-preview.1.902
    • Microsoft.Build.NuGetSdkResolver
    • NuGet.Build.Tasks
    • NuGet.Build.Tasks.Console
    • NuGet.Build.Tasks.Pack
    • NuGet.CommandLine.XPlat
    • NuGet.Commands
    • NuGet.Common
    • NuGet.Configuration
    • NuGet.Credentials
    • NuGet.DependencyResolver.Core
    • NuGet.Frameworks
    • NuGet.LibraryModel
    • NuGet.Localization
    • NuGet.Packaging
    • NuGet.ProjectModel
    • NuGet.Protocol
    • NuGet.Versioning
  • From 10.0.0-beta.25479.108 to 10.0.0-beta.25508.102
    • Microsoft.Build.Tasks.Git
    • Microsoft.SourceLink.AzureRepos.Git
    • Microsoft.SourceLink.Bitbucket.Git
    • Microsoft.SourceLink.Common
    • Microsoft.SourceLink.GitHub
    • Microsoft.SourceLink.GitLab
  • From 5.0.0-2.25479.108 to 5.1.0-1.25508.102
    • Microsoft.CodeAnalysis
    • Microsoft.CodeAnalysis.BuildClient
    • Microsoft.CodeAnalysis.CSharp
    • Microsoft.CodeAnalysis.CSharp.CodeStyle
    • Microsoft.CodeAnalysis.CSharp.Features
    • Microsoft.CodeAnalysis.CSharp.Workspaces
    • Microsoft.CodeAnalysis.PublicApiAnalyzers
    • Microsoft.CodeAnalysis.Workspaces.Common
    • Microsoft.CodeAnalysis.Workspaces.MSBuild
    • Microsoft.Net.Compilers.Toolset
    • Microsoft.Net.Compilers.Toolset.Framework
  • From 2.0.0-preview.1.25479.108 to 2.0.0-preview.1.25508.102
    • Microsoft.Deployment.DotNet.Releases
  • From 2.2.0-beta.25479.108 to 2.2.0-beta.25508.102
    • Microsoft.DiaSymReader
  • From 11.0.0-beta.25479.108 to 11.0.0-beta.25508.102
    • Microsoft.DotNet.Arcade.Sdk
    • Microsoft.DotNet.Build.Tasks.Installers
    • Microsoft.DotNet.Build.Tasks.Templating
    • Microsoft.DotNet.Build.Tasks.Workloads
    • Microsoft.DotNet.Helix.Sdk
    • Microsoft.DotNet.SignTool
    • Microsoft.DotNet.XliffTasks
    • Microsoft.DotNet.XUnitExtensions
  • From 14.0.100-rc2.25479.108 to 14.0.0-alpha1.25508.102
    • Microsoft.FSharp.Compiler
  • From 11.0.100-alpha.1.25479.108 to 11.0.100-alpha.1.25508.102
    • Microsoft.TemplateEngine.Abstractions
    • Microsoft.TemplateEngine.Authoring.TemplateVerifier
    • Microsoft.TemplateEngine.Edge
    • Microsoft.TemplateEngine.Mocks
    • Microsoft.TemplateEngine.Orchestrator.RunnableProjects
    • Microsoft.TemplateEngine.TestHelper
    • Microsoft.TemplateEngine.Utils
    • Microsoft.TemplateSearch.Common
    • Microsoft.TemplateSearch.TemplateDiscovery
  • From 3.2.0-preview.25479.108 to 3.2.0-preview.25508.102
    • Microsoft.Web.Xdt
  • From 2.0.0-rc.1.25479.108 to 2.0.0-rc.1.25508.102
    • System.CommandLine

Associated changes in source repos

Updated Dependencies:
dotnet-dev-certs, dotnet-user-jwts, dotnet-user-secrets, Microsoft.AspNetCore.Analyzers, Microsoft.AspNetCore.App.Ref, Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.Authentication.Facebook, Microsoft.AspNetCore.Authentication.Google, Microsoft.AspNetCore.Authentication.MicrosoftAccount, Microsoft.AspNetCore.Authorization, Microsoft.AspNetCore.Components, Microsoft.AspNetCore.Components.Analyzers, Microsoft.AspNetCore.Components.Forms, Microsoft.AspNetCore.Components.SdkAnalyzers, Microsoft.AspNetCore.Components.Web, Microsoft.AspNetCore.Components.WebAssembly, Microsoft.AspNetCore.Components.WebAssembly.Server, Microsoft.AspNetCore.Components.WebView, Microsoft.AspNetCore.DeveloperCertificates.XPlat, Microsoft.AspNetCore.Metadata, Microsoft.AspNetCore.Mvc.Analyzers, Microsoft.AspNetCore.Mvc.Api.Analyzers, Microsoft.AspNetCore.TestHost, Microsoft.Bcl.AsyncInterfaces, Microsoft.DotNet.Web.ItemTemplates.10.0, Microsoft.DotNet.Web.ProjectTemplates.10.0, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Embedded, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.ObjectPool, Microsoft.JSInterop, Microsoft.NET.HostModel, Microsoft.NET.ILLink.Tasks, Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.win-x64, Microsoft.NET.Sdk.WindowsDesktop, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Win32.SystemEvents, Microsoft.WindowsDesktop.App.Internal, Microsoft.WindowsDesktop.App.Ref, System.CodeDom, System.ComponentModel.Composition, System.Composition.AttributedModel, System.Composition.Convention, System.Composition.Hosting, System.Composition.Runtime, System.Composition.TypedParts, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Formats.Asn1, System.IO.Hashing, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Security.Cryptography.Pkcs, System.Security.Cryptography.ProtectedData, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encoding.CodePages, System.Text.Json, System.Windows.Extensions (Version 10.0.0-rc.1.25479.108 -> 10.0.0-rc.1.25506.102)
Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal, Microsoft.CodeAnalysis.Razor.Tooling.Internal, Microsoft.NET.Sdk.Razor.SourceGenerators.Transport (Version 10.0.0-preview.25479.108 -> 10.0.0-preview.25506.102)
Microsoft.Build, Microsoft.Build.Localization (Version 18.0.0-preview-25479-108 -> 18.1.0-preview-25506-102)
Microsoft.Build.NuGetSdkResolver, NuGet.Build.Tasks, NuGet.Build.Tasks.Console, NuGet.Build.Tasks.Pack, NuGet.CommandLine.XPlat, NuGet.Commands, NuGet.Common, NuGet.Configuration, NuGet.Credentials, NuGet.DependencyResolver.Core, NuGet.Frameworks, NuGet.LibraryModel, NuGet.Localization, NuGet.Packaging, NuGet.ProjectModel, NuGet.Protocol, NuGet.Versioning (Version 7.0.0-preview.1.48008 -> 7.0.0-preview.1.702)
Microsoft.Build.Tasks.Git, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.Bitbucket.Git, Microsoft.SourceLink.Common, Microsoft.SourceLink.GitHub, Microsoft.SourceLink.GitLab (Version 10.0.0-beta.25479.108 -> 10.0.0-beta.25506.102)
Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.BuildClient, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.CSharp.CodeStyle, Microsoft.CodeAnalysis.CSharp.Features, Microsoft.CodeAnalysis.CSharp.Workspaces, Microsoft.CodeAnalysis.PublicApiAnalyzers, Microsoft.CodeAnalysis.Workspaces.Common, Microsoft.CodeAnalysis.Workspaces.MSBuild, Microsoft.Net.Compilers.Toolset, Microsoft.Net.Compilers.Toolset.Framework (Version 5.0.0-2.25479.108 -> 5.1.0-1.25506.102)
Microsoft.Deployment.DotNet.Releases (Version 2.0.0-preview.1.25479.108 -> 2.0.0-preview.1.25506.102)
Microsoft.DiaSymReader (Version 2.2.0-beta.25479.108 -> 2.2.0-beta.25506.102)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.SignTool, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 11.0.0-beta.25479.108 -> 11.0.0-beta.25506.102)
Microsoft.FSharp.Compiler (Version 14.0.100-rc2.25479.108 -> 14.0.100-rc2.25506.102)
Microsoft.NET.Test.Sdk, Microsoft.TestPlatform.Build, Microsoft.TestPlatform.CLI (Version 18.0.0-preview-25479-108 -> 18.0.0-preview-25506-102)
Microsoft.TemplateEngine.Abstractions, Microsoft.TemplateEngine.Authoring.TemplateVerifier, Microsoft.TemplateEngine.Edge, Microsoft.TemplateEngine.Mocks, Microsoft.TemplateEngine.Orchestrator.RunnableProjects, Microsoft.TemplateEngine.TestHelper, Microsoft.TemplateEngine.Utils, Microsoft.TemplateSearch.Common, Microsoft.TemplateSearch.TemplateDiscovery (Version 11.0.100-alpha.1.25479.108 -> 11.0.100-alpha.1.25506.102)
Microsoft.Web.Xdt (Version 3.2.0-preview.25479.108 -> 3.2.0-preview.25506.102)
System.CommandLine (Version 2.0.0-rc.1.25479.108 -> 2.0.0-rc.1.25506.102)
@dotnet-maestro dotnet-maestro Bot requested a review from a team as a code owner October 7, 2025 02:15
@github-actions

github-actions Bot commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

This PR is targeting main, which is now for .NET 11-facing work. If you intended to target .NET 10, either retarget this PR to release/10.0.1xx or make sure you backport the change to release/10.0.1xx after merging. See #50394 for more details.

@jjonescz

jjonescz commented Oct 7, 2025

Copy link
Copy Markdown
Member

@dotnet/roslyn-ide were there some changes to SyntaxGenerator that could explain this change (addition of global:: in enum attribute arguments) in the observed behavior in ApiDiff tests here?

image

@CyrusNajmabadi you seem to have made changes in that area.

@CyrusNajmabadi

Copy link
Copy Markdown
Contributor

yes. it is likely: dotnet/roslyn#80443

The above code seems verbose, but not problematically so.

@jjonescz

jjonescz commented Oct 7, 2025

Copy link
Copy Markdown
Member

So I guess the tests need to be updated. Tagging @dotnet/area-infrastructure-libraries as ApiDiff owners.

dotnet-maestro Bot and others added 4 commits October 8, 2025 02:20
Updated Dependencies:
dotnet-dev-certs, dotnet-user-jwts, dotnet-user-secrets, Microsoft.AspNetCore.Analyzers, Microsoft.AspNetCore.App.Ref, Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.Authentication.Facebook, Microsoft.AspNetCore.Authentication.Google, Microsoft.AspNetCore.Authentication.MicrosoftAccount, Microsoft.AspNetCore.Authorization, Microsoft.AspNetCore.Components, Microsoft.AspNetCore.Components.Analyzers, Microsoft.AspNetCore.Components.Forms, Microsoft.AspNetCore.Components.SdkAnalyzers, Microsoft.AspNetCore.Components.Web, Microsoft.AspNetCore.Components.WebAssembly, Microsoft.AspNetCore.Components.WebAssembly.Server, Microsoft.AspNetCore.Components.WebView, Microsoft.AspNetCore.DeveloperCertificates.XPlat, Microsoft.AspNetCore.Metadata, Microsoft.AspNetCore.Mvc.Analyzers, Microsoft.AspNetCore.Mvc.Api.Analyzers, Microsoft.AspNetCore.TestHost, Microsoft.Bcl.AsyncInterfaces, Microsoft.DotNet.Web.ItemTemplates.10.0, Microsoft.DotNet.Web.ProjectTemplates.10.0, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Embedded, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.ObjectPool, Microsoft.JSInterop, Microsoft.NET.HostModel, Microsoft.NET.ILLink.Tasks, Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.win-x64, Microsoft.NET.Sdk.WindowsDesktop, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Win32.SystemEvents, Microsoft.WindowsDesktop.App.Internal, Microsoft.WindowsDesktop.App.Ref, System.CodeDom, System.ComponentModel.Composition, System.Composition.AttributedModel, System.Composition.Convention, System.Composition.Hosting, System.Composition.Runtime, System.Composition.TypedParts, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Formats.Asn1, System.IO.Hashing, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Security.Cryptography.Pkcs, System.Security.Cryptography.ProtectedData, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encoding.CodePages, System.Text.Json, System.Windows.Extensions (Version 10.0.0-rc.1.25506.102 -> 10.0.0-rc.1.25507.102)
Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal, Microsoft.CodeAnalysis.Razor.Tooling.Internal, Microsoft.NET.Sdk.Razor.SourceGenerators.Transport (Version 10.0.0-preview.25506.102 -> 10.0.0-preview.25507.102)
Microsoft.Build, Microsoft.Build.Localization (Version 18.1.0-preview-25506-102 -> 18.1.0-preview-25507-102)
Microsoft.Build.NuGetSdkResolver, NuGet.Build.Tasks, NuGet.Build.Tasks.Console, NuGet.Build.Tasks.Pack, NuGet.CommandLine.XPlat, NuGet.Commands, NuGet.Common, NuGet.Configuration, NuGet.Credentials, NuGet.DependencyResolver.Core, NuGet.Frameworks, NuGet.LibraryModel, NuGet.Localization, NuGet.Packaging, NuGet.ProjectModel, NuGet.Protocol, NuGet.Versioning (Version 7.0.0-preview.1.702 -> 7.0.0-preview.1.802)
Microsoft.Build.Tasks.Git, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.Bitbucket.Git, Microsoft.SourceLink.Common, Microsoft.SourceLink.GitHub, Microsoft.SourceLink.GitLab (Version 10.0.0-beta.25506.102 -> 10.0.0-beta.25507.102)
Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.BuildClient, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.CSharp.CodeStyle, Microsoft.CodeAnalysis.CSharp.Features, Microsoft.CodeAnalysis.CSharp.Workspaces, Microsoft.CodeAnalysis.PublicApiAnalyzers, Microsoft.CodeAnalysis.Workspaces.Common, Microsoft.CodeAnalysis.Workspaces.MSBuild, Microsoft.Net.Compilers.Toolset, Microsoft.Net.Compilers.Toolset.Framework (Version 5.1.0-1.25506.102 -> 5.1.0-1.25507.102)
Microsoft.Deployment.DotNet.Releases (Version 2.0.0-preview.1.25506.102 -> 2.0.0-preview.1.25507.102)
Microsoft.DiaSymReader (Version 2.2.0-beta.25506.102 -> 2.2.0-beta.25507.102)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.SignTool, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 11.0.0-beta.25506.102 -> 11.0.0-beta.25507.102)
Microsoft.FSharp.Compiler (Version 14.0.100-rc2.25506.102 -> 14.0.0-alpha1.25507.102)
Microsoft.NET.Test.Sdk, Microsoft.TestPlatform.Build, Microsoft.TestPlatform.CLI (Version 18.0.0-preview-25506-102 -> 18.1.0-preview-25507-102)
Microsoft.TemplateEngine.Abstractions, Microsoft.TemplateEngine.Authoring.TemplateVerifier, Microsoft.TemplateEngine.Edge, Microsoft.TemplateEngine.Mocks, Microsoft.TemplateEngine.Orchestrator.RunnableProjects, Microsoft.TemplateEngine.TestHelper, Microsoft.TemplateEngine.Utils, Microsoft.TemplateSearch.Common, Microsoft.TemplateSearch.TemplateDiscovery (Version 11.0.100-alpha.1.25506.102 -> 11.0.100-alpha.1.25507.102)
Microsoft.Web.Xdt (Version 3.2.0-preview.25506.102 -> 3.2.0-preview.25507.102)
System.CommandLine (Version 2.0.0-rc.1.25506.102 -> 2.0.0-rc.1.25507.102)
Updated Dependencies:
dotnet-dev-certs, dotnet-user-jwts, dotnet-user-secrets, Microsoft.AspNetCore.Analyzers, Microsoft.AspNetCore.App.Ref, Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.Authentication.Facebook, Microsoft.AspNetCore.Authentication.Google, Microsoft.AspNetCore.Authentication.MicrosoftAccount, Microsoft.AspNetCore.Authorization, Microsoft.AspNetCore.Components, Microsoft.AspNetCore.Components.Analyzers, Microsoft.AspNetCore.Components.Forms, Microsoft.AspNetCore.Components.SdkAnalyzers, Microsoft.AspNetCore.Components.Web, Microsoft.AspNetCore.Components.WebAssembly, Microsoft.AspNetCore.Components.WebAssembly.Server, Microsoft.AspNetCore.Components.WebView, Microsoft.AspNetCore.DeveloperCertificates.XPlat, Microsoft.AspNetCore.Metadata, Microsoft.AspNetCore.Mvc.Analyzers, Microsoft.AspNetCore.Mvc.Api.Analyzers, Microsoft.AspNetCore.TestHost, Microsoft.Bcl.AsyncInterfaces, Microsoft.DotNet.Web.ItemTemplates.10.0, Microsoft.DotNet.Web.ProjectTemplates.10.0, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Embedded, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.ObjectPool, Microsoft.JSInterop, Microsoft.NET.HostModel, Microsoft.NET.ILLink.Tasks, Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.win-x64, Microsoft.NET.Sdk.WindowsDesktop, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Win32.SystemEvents, Microsoft.WindowsDesktop.App.Internal, Microsoft.WindowsDesktop.App.Ref, System.CodeDom, System.ComponentModel.Composition, System.Composition.AttributedModel, System.Composition.Convention, System.Composition.Hosting, System.Composition.Runtime, System.Composition.TypedParts, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Formats.Asn1, System.IO.Hashing, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Security.Cryptography.Pkcs, System.Security.Cryptography.ProtectedData, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encoding.CodePages, System.Text.Json, System.Windows.Extensions (Version 10.0.0-rc.1.25507.102 -> 10.0.0-rc.1.25508.102)
Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal, Microsoft.CodeAnalysis.Razor.Tooling.Internal, Microsoft.NET.Sdk.Razor.SourceGenerators.Transport (Version 10.0.0-preview.25507.102 -> 10.0.0-preview.25508.102)
Microsoft.Build, Microsoft.Build.Localization, Microsoft.NET.Test.Sdk, Microsoft.TestPlatform.Build, Microsoft.TestPlatform.CLI (Version 18.1.0-preview-25507-102 -> 18.1.0-preview-25508-102)
Microsoft.Build.NuGetSdkResolver, NuGet.Build.Tasks, NuGet.Build.Tasks.Console, NuGet.Build.Tasks.Pack, NuGet.CommandLine.XPlat, NuGet.Commands, NuGet.Common, NuGet.Configuration, NuGet.Credentials, NuGet.DependencyResolver.Core, NuGet.Frameworks, NuGet.LibraryModel, NuGet.Localization, NuGet.Packaging, NuGet.ProjectModel, NuGet.Protocol, NuGet.Versioning (Version 7.0.0-preview.1.802 -> 7.0.0-preview.1.902)
Microsoft.Build.Tasks.Git, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.Bitbucket.Git, Microsoft.SourceLink.Common, Microsoft.SourceLink.GitHub, Microsoft.SourceLink.GitLab (Version 10.0.0-beta.25507.102 -> 10.0.0-beta.25508.102)
Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.BuildClient, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.CSharp.CodeStyle, Microsoft.CodeAnalysis.CSharp.Features, Microsoft.CodeAnalysis.CSharp.Workspaces, Microsoft.CodeAnalysis.PublicApiAnalyzers, Microsoft.CodeAnalysis.Workspaces.Common, Microsoft.CodeAnalysis.Workspaces.MSBuild, Microsoft.Net.Compilers.Toolset, Microsoft.Net.Compilers.Toolset.Framework (Version 5.1.0-1.25507.102 -> 5.1.0-1.25508.102)
Microsoft.Deployment.DotNet.Releases (Version 2.0.0-preview.1.25507.102 -> 2.0.0-preview.1.25508.102)
Microsoft.DiaSymReader (Version 2.2.0-beta.25507.102 -> 2.2.0-beta.25508.102)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.SignTool, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 11.0.0-beta.25507.102 -> 11.0.0-beta.25508.102)
Microsoft.FSharp.Compiler (Version 14.0.0-alpha1.25507.102 -> 14.0.0-alpha1.25508.102)
Microsoft.TemplateEngine.Abstractions, Microsoft.TemplateEngine.Authoring.TemplateVerifier, Microsoft.TemplateEngine.Edge, Microsoft.TemplateEngine.Mocks, Microsoft.TemplateEngine.Orchestrator.RunnableProjects, Microsoft.TemplateEngine.TestHelper, Microsoft.TemplateEngine.Utils, Microsoft.TemplateSearch.Common, Microsoft.TemplateSearch.TemplateDiscovery (Version 11.0.100-alpha.1.25507.102 -> 11.0.100-alpha.1.25508.102)
Microsoft.Web.Xdt (Version 3.2.0-preview.25507.102 -> 3.2.0-preview.25508.102)
System.CommandLine (Version 2.0.0-rc.1.25507.102 -> 2.0.0-rc.1.25508.102)
@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

Important

The source repository has received code changes from an opposite flow. Any additional codeflows into this PR may potentially result in lost changes.
Please continue with one of the following options:

  1. Close or merge this PR and let the codeflow continue normally
  2. Close or merge this PR and receive the new codeflow immediately by triggering the subscription:
    darc trigger-subscriptions --id 94ba9a9b-a084-4c1e-bf44-d0c711c17773
  3. Force-flow new changes into this PR at your own risk (some PR commits might be reverted):
    darc trigger-subscriptions --force --id 94ba9a9b-a084-4c1e-bf44-d0c711c17773

In case of unclarities, consult the FAQ or tag @dotnet/product-construction for assistance.

@ViktorHofer

Copy link
Copy Markdown
Member

Note that SBRP uses GenAPI (which would be impacted by the above change) to generate the public api source for a given assembly. My assumption is that this change will require all the checked-in files to get regenerated.

https://github.com/dotnet/source-build-reference-packages/blob/5a84592232f09966b07e9cc829dc9c3bf3c27f7d/src/referencePackages/src/nuget.packaging/6.13.2/lib/net8.0/NuGet.Packaging.cs#L431 as an example. The repo has probably a thousand of those files.

@jjonescz

Copy link
Copy Markdown
Member

My assumption is that this change will require all the checked-in files to get regenerated.
The repo has probably a thousand of those files.

^ @CyrusNajmabadi @dotnet/area-infrastructure-libraries FYI

@CyrusNajmabadi

Copy link
Copy Markdown
Contributor

Is that a problem? Or just a statement about impact? Thanks.

@ViktorHofer

Copy link
Copy Markdown
Member

a statement about impact

This. It means that SBRP will need to react when dotnet/dotnet backflows into the repo and updates GenAPI. cc @dotnet/source-build

Can you elaborate on why the global:: prefix now gets appended to attributes?

@ViktorHofer

ViktorHofer commented Oct 13, 2025

Copy link
Copy Markdown
Member

cc @ericstj - as we post the ApiDiff output as part of our public api change release notes.

@CyrusNajmabadi

Copy link
Copy Markdown
Contributor

Can you elaborate on why the global:: prefix now gets appended to attributes?

We were previously creating incorrectly shaped trees. We were previously creating a TypeSyntax instead of a MemberAccessExpressionSyntax. This changes that to generate the right syntax.

It looks like in our MemberAccessExpression generating code we add global:: as part of that.

@ericstj

ericstj commented Oct 13, 2025

Copy link
Copy Markdown
Member

I think this tool was trying to remove global with

internal class GlobalPrefixRemover : CSharpSyntaxRewriter
so something changed to make that no longer work.

@ericstj ericstj requested a review from a team as a code owner October 13, 2025 22:17
@marcpopMSFT

Copy link
Copy Markdown
Member

@dotnet/product-construction are the downgrades from fsharp and nuget expected? Seems like they rebranded the prerelease version label for these without updating the version number.

Dependency Microsoft.FSharp.Compiler was downgraded from 14.0.100-rc2.25479.108 to 14.0.0-alpha1.25508.102
Dependency NuGet.Build.Tasks was downgraded from 7.0.0-preview.1.48008 to 7.0.0-preview.1.902

@mmitche

mmitche commented Oct 14, 2025

Copy link
Copy Markdown
Member

Downgrades from NuGet expected, FSharp looks wrong...the build is later in date, but I would have expected an update in major or minor.

@ViktorHofer

Copy link
Copy Markdown
Member

This looks related to fsharp's rebranding: dotnet/fsharp@a5f0301

The 14 version probably also needs an update?

cc @T-Gro @vzarytovskii

@mmitche

mmitche commented Oct 14, 2025

Copy link
Copy Markdown
Member

This looks related to fsharp's rebranding: dotnet/fsharp@a5f0301

The 14 version probably also needs an update?

cc @T-Gro @vzarytovskii

I'm not even seeing where the 14 comes from there...odd.

@ViktorHofer

Copy link
Copy Markdown
Member

@jaredpar

Copy link
Copy Markdown
Member

@phil-allen-msft and @T-Gro assigned for the two remaining issues.

Note: this is impacting Aspire scenarios and general code flow. We're at 1w open right now.

@marcpopMSFT

Copy link
Copy Markdown
Member

I swear that the BA check was passing yesterday but someone reran it. Apparently there's not good logging of that so I can't be sure. Rerunning the failures but if BA is green, the downgrades are safe (fsharp needs to be fixed but it's not a problem if we take it).

@jaredpar

Copy link
Copy Markdown
Member
/datadisks/disk1/work/A41208BE/t/dotnetSdkTests.fTf42m6v/IsAotCompatib---9A376707/ClassLibTest/ClassLibTest.csproj : warning NU1900: Error occurred while getting package vulnerability data: Response status code does not indicate success: 401 (Unauthorized).
/datadisks/disk1/work/A41208BE/t/dotnetSdkTests.fTf42m6v/IsAotCompatib---9A376707/ClassLibTest/ClassLibTest.csproj : warning NU1900: Error occurred while getting package vulnerability data: Response status code does not indicate success: 401 (Unauthorized).
/datadisks/disk1/work/A41208BE/t/dotnetSdkTests.fTf42m6v/IsAotCompatib---9A376707/ClassLibTest/ClassLibTest.csproj : warning NU1900: Error occurred while getting package vulnerability data: Response status code does not indicate success: 401 (Unauthorized).
/datadisks/disk1/work/A41208BE/t/dotnetSdkTests.fTf42m6v/IsAotCompatib---9A376707/ClassLibTest/ClassLibTest.csproj : warning NU1900: Error occurred while getting package vulnerability data: Response status code does not indicate success: 401 (Unauthorized).
/datadisks/disk1/work/A41208BE/t/dotnetSdkTests.fTf42m6v/IsAotCompatib---9A376707/ClassLibTest/ClassLibTest.csproj : warning NU1900: Error occurred while getting package vulnerability data: Response status code does not indicate success: 401 (Unauthorized).
/datadisks/disk1/work/A41208BE/t/dotnetSdkTests.fTf42m6v/IsAotCompatib---9A376707/ClassLibTest/ClassLibTest.csproj : warning NU1900: Error occurred while getting package vulnerability data: Response status code does not indicate success: 401 (Unauthorized).

@marcpopMSFT looks like at least some of the tests were running when the NuGet 401 was occurring.

@jaredpar

Copy link
Copy Markdown
Member

Removed @phil-allen-msft as the roslyn issue seems addressed

@marcpopMSFT

Copy link
Copy Markdown
Member

did nuget have an outage?

@T-Gro

T-Gro commented Oct 15, 2025

Copy link
Copy Markdown
Member

This looks related to fsharp's rebranding: dotnet/fsharp@a5f0301

The 14 version probably also needs an update?

cc @T-Gro @vzarytovskii

Yes, this is consequence of the rebranding.
The VS tools have a separate versioning scheme from F# (which follows .NET numbers).

But since the preview prefixes are now added, it treats "rc2" (from .NET10) into "alpha" (of .NET11 nevertheless - this is pulling it from fsharp/VMR's main) as a downgrade if that VS tooling number has not been increased as well.

I raised a change to increase that number in F#'s main to unblock this.

@jaredpar jaredpar merged commit 668c6c9 into main Oct 15, 2025
31 of 33 checks passed
@jaredpar jaredpar deleted the darc-main-0a5ff37f-65a6-40ce-93fd-0f4730439acc branch October 15, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.