Remove RIDS in CompareMsftToSbAssemblyVersions test#42022
Merged
Conversation
MichaelSimons
approved these changes
Jul 8, 2024
3 tasks
3 tasks
Member
Author
|
@dotnet/source-build-internal - the failures are unrelated to these changes. Can someone please bypass the checks for this PR? These changes are necessary for a green SDK diff pipeline run. TIA |
This was referenced Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes dotnet/source-build#4493
When testing the changes in #41929, the
CompareMsftToSbAssemblyVersionswas continuing to fail with the following error message:This file should fall under the following exclusion that exists in the exclusions file:
./packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/|sb. Upon investigation, I discovered that the issue was that unlike theCompareMsftToSbFileListtest, theCompareMsftToSbAssemblyVersionstest does not remove the RID from the file.The fix here was to 1) Remove the RID from the SB file, and 2) replace the placeholder rids with matching patterns when attempting to file match to the Msft SDK.
We should merge this before merging in #41929