[release/9.0-preview1] [NativeAOT] ObjWriter: Fix over-alignment of .eh_frame entries#97457
Conversation
ghost
added
the
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #96817 to release/9.0-preview1 /cc @carlossanlop @filipnavara Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.] Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.] Testing[How was the fix verified? How was the issue missed previously? What tests were added?] Risk[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.] IMPORTANT: If this backport is for a servicing release, please verify that:
|
|
Approved by Tactics via email. |
3 participants
Backport of #96817 to release/9.0-preview1
/cc @carlossanlop @filipnavara
Customer Impact
We noticed when switching from the old to the new ObjWriter that the debug symbols were larger than before.
The important piece of this change is that it groups all the ObjWriter replacement changes into Preview 1, rather than splitting across multiple releases.
Regression
This regression was introduced by the ObjWriter change, which happened a few weeks ago.
Testing
Manual testing
Risk
Medium, because we have very limited unit testing of the symbol quality coming out of Native AOT. This is the primary reason to take this change in Preview 1 -- if we put these changes in ASAP, we can get feedback from users if they broke anything and have plenty of time to change it before 9.0 ships.