Bump branding to .NET 9.0 Preview 1#97336
Merged
carlossanlop merged 1 commit intodotnet:mainfrom Jan 22, 2024
carlossanlop:BrandingPreview1
Merged
Bump branding to .NET 9.0 Preview 1#97336carlossanlop merged 1 commit intodotnet:mainfrom carlossanlop:BrandingPreview1
carlossanlop merged 1 commit intodotnet:mainfrom
carlossanlop:BrandingPreview1
Conversation
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsI intend to merge this PR before the snap. After the snap, I'll submit an additional PR to point main to Preview 2. I'm testing this works by locally buildin then packing an in-box assembly to confirm the correct branding is indicated in the generated package.
|
ViktorHofer
approved these changes
Jan 22, 2024
lewing
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I intend to merge this PR before the snap.
After the snap, I'll submit an additional PR to point main to Preview 2.
I'm testing this works by locally building and then packing an in-box assembly to confirm the correct branding is indicated in the generated package.
Confirmed it's working:
dotnet pack src/libraries/System.Formats.Asn1/src/System.Formats.Asn1.csproj /p:OfficialBuild=true /p:ContinuousIntegrationBuild=trueOutput: