Skip to content

Don't shorten OCSP expriation on failed server OCSP fetch #96972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wfurt merged 2 commits into from
Jan 16, 2024
Merged

Don't shorten OCSP expriation on failed server OCSP fetch #96972

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13acf6d
Don't shorten OCSP expriation on failed server OCSP fetch
rzikm Jan 15, 2024
0d40603
Code review feedback
rzikm Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...ibraries/System.Net.Security/src/System/Net/Security/SslStreamCertificateContext.Linux.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,11 +282,10 @@ partial void AddRootCertificate(X509Certificate2? rootCertificate, ref bool tran
_pendingDownload = null;
if (ret == null)
{
// all download attempts failed, don't try again for 5 seconds.
// Note that if server does not send OCSP staples, clients may still
// contact OCSP responders directly.
// All download attempts failed, don't try again for 5 seconds.
// This backoff will be applied only if the OCSP staple is not expired.
// If it is expired, we will force-refresh it during next GetOcspResponseAsync call.
_nextDownload = DateTimeOffset.UtcNow.AddSeconds(5);
_ocspExpiration = _nextDownload;
}
return ret;
}
Expand Down