Skip to content

Recover from failed OCSP download. #96448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzikm merged 2 commits into from
Jan 10, 2024
+10 −1
Merged

Recover from failed OCSP download. #96448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
783f8a5
Recover from failed OCSP check.
rzikm Jan 3, 2024
aa4f9ed
Add 5s back-off after failed OCSP querry
rzikm Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...ibraries/System.Net.Security/src/System/Net/Security/SslStreamCertificateContext.Linux.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,6 @@ partial void AddRootCertificate(X509Certificate2? rootCertificate, ref bool tran
_ocspResponse = ret;
_ocspExpiration = expiration;
_nextDownload = nextCheckA < nextCheckB ? nextCheckA : nextCheckB;
_pendingDownload = null;
break;
}
}
Comment thread
rzikm marked this conversation as resolved.
Expand All @@ -256,6 +255,16 @@ partial void AddRootCertificate(X509Certificate2? rootCertificate, ref bool tran
ArrayPool<char>.Shared.Return(rentedChars.Array!);
GC.KeepAlive(TargetCertificate);
GC.KeepAlive(caCert);

_pendingDownload = null;
if (ret == null)
{
// all download attempts failed, don't try again for 5 seconds.
// Note that if server does not send OCSP staples, clients may still
// contact OCSP responders directly.
_nextDownload = DateTimeOffset.UtcNow.AddSeconds(5);
_ocspExpiration = _nextDownload;
}
return ret;
}
}
Expand Down