Skip to content

[iOS][non-icu] HybridGlobalization fix localized DisplayName and LanguageName#95786

Merged
mkhamoyan merged 3 commits into
dotnet:mainfrom
mkhamoyan:hybrid_fix_95427
Dec 12, 2023
Merged

[iOS][non-icu] HybridGlobalization fix localized DisplayName and LanguageName#95786
mkhamoyan merged 3 commits into
dotnet:mainfrom
mkhamoyan:hybrid_fix_95427

Conversation

@mkhamoyan

@mkhamoyan mkhamoyan commented Dec 8, 2023

Copy link
Copy Markdown
Contributor

Fix localized DisplayName and LanguageName for hybrid mode and enable tests on Apple mobile platforms.

Fixes #95427
cc @SamMonoRT

@ghost

ghost commented Dec 8, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Implement localized DisplayName and LanguageName for hybrid mode and enable tests on Apple mobile platforms.

Fixes #95427
cc @SamMonoRT

Author: mkhamoyan
Assignees: mkhamoyan
Labels:

area-System.Globalization, os-ios

Milestone: -

@mkhamoyan mkhamoyan requested a review from steveisok December 8, 2023 13:46
@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-ioslikesimulator

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-ioslike

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-maccatalyst

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan mkhamoyan changed the title [iOS][non-icu] HybridGlobalization implement localized DisplayName and LanguageName [iOS][non-icu] HybridGlobalization fix localized DisplayName and LanguageName Dec 8, 2023
@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-ioslikesimulator

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-ioslike

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-maccatalyst

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-maccatalyst

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-ioslike

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-ioslikesimulator

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan mkhamoyan marked this pull request as ready for review December 11, 2023 13:05
Comment thread src/native/libs/System.Globalization.Native/pal_locale.m

@mdh1418 mdh1418 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mkhamoyan mkhamoyan merged commit 0a940f9 into dotnet:main Dec 12, 2023
@mkhamoyan mkhamoyan deleted the hybrid_fix_95427 branch December 12, 2023 13:54
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS] CultureInfo.DisplayName only shows abbreviation

3 participants