Do not release frozen segment if we failed extending it

[MichalStrehovsky]

Maybe I'm missing something, but if we try to commit more of the reserved segment and this fails, it doesn't feel right to release the whole thing. The previously committed part of the segment is still in use.

[EgorBo]

This was a suggestion from @jkotas:

I don't have a strong opinion here, presumably if Commit fails we're in a bad state anyway?

[MichalStrehovsky]

This was a suggestion from @jkotas:

That comment seems to be for the call in the constructor of FrozenObjectSegment - i.e. we reserved and immedially try to commit, but fail there. Nobody can be using that memory yet so we can just have to release.

But the place where I'm deleting the free is in TryAllocateObject. Unless I'm missing something, we are already using this segment, we just failed to extend the commit range of it. VirtualAlloc (on Windows at least) would fail like that if we're in low memory situation (reserve will succeed even for unreasonable amounts of memory, but actually commiting physical storage can fail).

[EgorBo]

That comment seems to be for the call in the constructor of FrozenObjectSegment

Ah, right, then sounds OK to have it, unless @jkotas has an opposite opinion

[jkotas]

Good catch