Skip to content

Fix Common.Tests.GetPrettyName_CannotRead_ReturnsNull test for root user #92695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wfurt merged 5 commits into from
Sep 29, 2023
Merged

Fix Common.Tests.GetPrettyName_CannotRead_ReturnsNull test for root user #92695

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9f8a6d
fix Common.Tests.GetPrettyName_CannotRead_ReturnsNull test for root user
sirntar Sep 27, 2023
dcf4c41
remove direct call to libc in Common.Tests.GetPrettyName_CannotRead_R…
sirntar Sep 27, 2023
5516afa
Update src/libraries/Common/tests/Tests/Interop/OSReleaseTests.cs
danmoseley Sep 27, 2023
eb3f9a0
split Common.Tests.OSReleaseTests.GetPrettyName_CannotRead_ReturnsNul…
sirntar Sep 28, 2023
774682f
replace ifs with ConditionalFact in Common.Tests.OSReleaseTests class
sirntar Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/libraries/Common/tests/Tests/Interop/OSReleaseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,29 @@ public void GetPrettyName_NoFile_ReturnsNull()
Assert.Null(name);
}

[Fact, PlatformSpecific(TestPlatforms.Linux)]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotPrivilegedProcess)), PlatformSpecific(TestPlatforms.Linux)]
public void GetPrettyName_CannotRead_ReturnsNull()
{
string path = CreateTestFile();
File.SetUnixFileMode(path, UnixFileMode.None);
Assert.ThrowsAny<Exception>(() => File.ReadAllText(path));

Assert.ThrowsAny<Exception>(() => File.ReadAllText(path));

string? name = Interop.OSReleaseFile.GetPrettyName(path);
Assert.Null(name);
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsPrivilegedProcess)), PlatformSpecific(TestPlatforms.Linux)]
public void GetPrettyName_NonePrivileges_CanRead_ReturnsNull()
{
string path = CreateTestFile();
File.SetUnixFileMode(path, UnixFileMode.None);

// If user have root permissions, kernel doesn't care about access privileges,
// so there is no point in expecting System.Exception
Assert.Equal(UnixFileMode.None, File.GetUnixFileMode(path));
// Because kernel ignored privileges check, file should be readable and empty
Assert.Equal("", File.ReadAllText(path));

string? name = Interop.OSReleaseFile.GetPrettyName(path);
Assert.Null(name);
Expand Down