Skip to content

Add missing STJ xml docs#92138

Merged
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:add-missing-json-docs
Sep 15, 2023
Merged

Add missing STJ xml docs#92138
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:add-missing-json-docs

Conversation

@eiriktsarpalis

Copy link
Copy Markdown
Member

Companion PR to dotnet/dotnet-api-docs#9297

@ghost

ghost commented Sep 15, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Companion PR to dotnet/dotnet-api-docs#9297

Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-System.Text.Json

Milestone: -

Comment thread src/libraries/System.Text.Json/src/CompatibilitySuppressions.xml Outdated

@carlossanlop carlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a node, and also there were some suggestions in the dotnet-api-docs PR in case you want to modify them here too.

@ViktorHofer ViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as no-merge until we resolve the public API discussion

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Sep 15, 2023
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Sep 15, 2023
@eiriktsarpalis eiriktsarpalis merged commit 8eeebd8 into dotnet:main Sep 15, 2023
@eiriktsarpalis eiriktsarpalis deleted the add-missing-json-docs branch September 15, 2023 20:17
@ghost ghost locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants