[mono][aot] Avoid compiling the same method multiple times during dedup.#91802
Merged
Conversation
kotlarmilos
approved these changes
Sep 8, 2023
kotlarmilos
left a comment
kotlarmilos
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks!
Question -- Hash key is MonoMethod *method. Would the same method from two assemblies share the pointer? Probably not?
vargaz
force-pushed
the
dedup-collect
branch
from
8dec8dd to
4221abc
Compare
Contributor
Author
These methods are generic instances, there is only one MonoMethod for each. |
Contributor
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Sep 8, 2023
Contributor
Author
|
/backport to release/8.0 |
Contributor
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6207700844 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.