Skip to content

[wasi] Work around WASI's mmap implementation not returning aligned m…#91761

Merged
vargaz merged 1 commit into
dotnet:mainfrom
vargaz:wasi-mmap
Sep 11, 2023
Merged

[wasi] Work around WASI's mmap implementation not returning aligned m…#91761
vargaz merged 1 commit into
dotnet:mainfrom
vargaz:wasi-mmap

Conversation

@vargaz

@vargaz vargaz commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

…emory.

Hopefully fixes #88501 and others.

@vargaz

vargaz commented Sep 7, 2023

Copy link
Copy Markdown
Contributor Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz changed the title [wasi] Work arounbd WASI's mmap implementation not returned aligned m… [wasi] Work arounbd WASI's mmap implementation not returning aligned m… Sep 7, 2023
…memory.

Some code in sgen like sgen_los_free_object () expects the return address to be aligned.

Hopefully fixes dotnet#88501 and others.
@vargaz

vargaz commented Sep 8, 2023

Copy link
Copy Markdown
Contributor Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz requested a review from lewing September 9, 2023 14:17
@vargaz vargaz changed the title [wasi] Work arounbd WASI's mmap implementation not returning aligned m… [wasi] Work around WASI's mmap implementation not returning aligned m… Sep 9, 2023
@vargaz

vargaz commented Sep 14, 2023

Copy link
Copy Markdown
Contributor Author

/backport to release/8.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6185744267

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasi] wasm trap: out of bounds memory access in sgen_gray_object_queue_trim_free_list

2 participants