Do not OCSP staple invalid OCSP responses#90200
Merged
Merged
Conversation
ghost
assigned
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones Issue DetailsLinux will currently staple an invalid OCSP response for as long as the OCSP responder will return an invalid response, such as a maintenance page. This changes the OCSP fetcher to discard the result if it could not be decoded. Fixes #89907
|
bartonjs
approved these changes
Aug 8, 2023
Member
Author
|
/azp run runtime-libraries-coreclr outerloop-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Outerloop failures look unrelated to me. |
Member
Author
|
/backport to release/7.0-staging |
Contributor
|
Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/5861087862 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux will currently staple an invalid OCSP response for as long as the OCSP responder will return an invalid response, such as a maintenance page.
This changes the OCSP fetcher to discard the result if it could not be decoded.
Fixes #89907