Abort host startup before the next phase#90183
Merged
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-extensions-hosting Issue DetailsChange host startup behavior so that the startup aborts before the next phase (Starting, Start and Started) if there are any exceptions. This makes more sense than the previous behavior of gathering all exceptions in Starting, Start, Started and then abort after Started -- e.g. if an exception occurs in Starting then Start and Started were still run in the previous behavior. Shutdown, however, will continue to have the same semantics where exceptions are gathered in Stopping, Stop and Stopped. This is to ensure all shutdown code is called. Fixes #88603
|
Tratcher
approved these changes
Aug 8, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change host startup behavior so that the startup aborts before the next phase (Starting, Start and Started) if there are any exceptions.
This makes more sense than the previous behavior of gathering all exceptions in Starting, Start, Started and then abort after Started -- e.g. if an exception occurs in Starting then Start and Started were still run in the previous behavior.
Shutdown, however, will continue to have the same semantics where exceptions are gathered in Stopping, Stop and Stopped. This is to ensure all shutdown code is called.
Fixes #88603