Use the same tracked contexts for event pipe and ETW in nativeaot#89902
Merged
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Details
|
LakshanF
approved these changes
Aug 4, 2023
LakshanF
left a comment
Contributor
There was a problem hiding this comment.
TLGTM. Thanks for these series of changes making ETW opt-in, the design coherent through the convoluted history and making it easier for us to switch to the python source gen to get ready for enabling future events easier!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnetruntime.cppand intoeventtrace.cppRH_ETW_CONTEXTand switch toMCGEN_TRACE_CONTEXT, which is what would be generated when nativeaot eventually gets onto the generation scriptsDotNETRuntimeinstead ofGC- most of the changes inEtwEvents.hwere just thisep_rt_providers_validate_all_disabled(uses the contexts)