Enable StressLogAnalyzer to read stress logs from old coreclr running with a new clrgc.#88852
Merged
jkoritzinsky merged 1 commit intoJul 14, 2023
Merged
Conversation
… with a new clrgc.
ghost
assigned
|
Tagging subscribers to this area: @dotnet/gc Issue Detailsnull
|
This was referenced Jul 13, 2023
Member
Author
|
All failures are tracked by known issues. |
PeterSolMS
reviewed
Jul 14, 2023
| uint32_t version; // must be 0x00010001 | ||
| uint32_t version; // must be >=0x00010001. | ||
| // 0x00010001 is the legacy short-offset format. | ||
| // 0x00010002 is the large-module-offset format introduced in .NET 8. |
Contributor
There was a problem hiding this comment.
Thank you for adding this comment!
Contributor
There was a problem hiding this comment.
Looks good to me - thank you!
PeterSolMS
approved these changes
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will only work with memory-mapped stresslogs. We don't have a versioning story for non-memory-mapped logs in non-SOS scenarios.