Backport #78136 to .NET 7#84936
Merged
jkoritzinsky merged 1 commit intodotnet:release/7.0-stagingfrom Apr 21, 2023
Merged
Conversation
* Use ForAttributeWithMetadataName instead of CreateSyntaxProvider * Remove unused code * Update export generator too
jkoritzinsky
requested review from
BrzVlad,
MichalStrehovsky,
SamMonoRT,
kg,
kotlarmilos,
lambdageek,
lateralusX,
lewing,
marek-safar,
pavelsavara,
radical,
thaystg and
vargaz
as code owners
jkoritzinsky
added
Servicing-consider
This comment was marked as outdated.
This comment was marked as outdated.
jkoritzinsky
removed request for
BrzVlad,
kg,
kotlarmilos,
lambdageek,
marek-safar,
radical and
vargaz
jkoritzinsky
removed request for
MichalStrehovsky,
SamMonoRT,
lateralusX and
thaystg
CyrusNajmabadi
approved these changes
Apr 17, 2023
RikkiGibson
approved these changes
Apr 17, 2023
jeffschwMSFT
approved these changes
Apr 17, 2023
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 7.0.x. please get a code review from the js interop team.
This was referenced Apr 17, 2023
pavelsavara
approved these changes
Apr 18, 2023
rbhanda
added
Servicing-approved
lewing
approved these changes
Apr 18, 2023
sharwell
added a commit
to sharwell/roslyn
that referenced
this pull request
Apr 24, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main PR #78136
Description
The JSImportGenerator and JSExportGenerator are causing VS performance issues due to not using more efficient APIs that Roslyn introduced in VS 17.4.
Customer Impact
Visual Studio experiences large amounts of allocations that show up in VS performance traces. #78136 (comment)
Regression
This is not a regression.
Testing
This change has been in .NET 8 for months, and very similar changes have been applied to other similar generators in .NET 7 since before release.
Risk
Low risk. This change is very mechanical and follows an established pattern to convert to using the new API and has been working in main for months.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.