Remove assert from Http3Connection.SendAsync#74348
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #74162. The assert in question was invalid, because we may close the connection gracefully without prior This PR also filters OperationAborted QuicExceptions from server-initiated streams since there is no need to call Abort when we already close the connection (and setting the _abortException in that case would be confusing).
|
rzikm
force-pushed
the
74162-Assert-failed-SystemNetHttpHttp3ConnectionSendAsync
branch
from
4963dff to
59e06e8
Compare
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2911235661 |
|
@rzikm backporting to release/7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
* Remove assert in System.Net.Http.Http3Connection.SendAsync * Minor change
ghost
locked as resolved and limited conversation to collaborators
3 participants
Fixes #74162.
The assert in question was invalid, because we may close the connection gracefully without prior
Http3Connection.Abortcall when responding to a GOAWAY.This PR also filters OperationAborted QuicExceptions from server-initiated streams since there is no need to call Abort when we already close the connection (and setting the _abortException in that case would be confusing).