Skip to content

Provide upgrade response details#71757

Merged
greenEkatherine merged 22 commits into
dotnet:mainfrom
greenEkatherine:provide-upgrade-response-details
Jul 12, 2022
Merged

Provide upgrade response details#71757
greenEkatherine merged 22 commits into
dotnet:mainfrom
greenEkatherine:provide-upgrade-response-details

Conversation

@greenEkatherine

Copy link
Copy Markdown
Contributor

Fixes #25918

Providing web socket upgrade response status code and headers.

@ghost

ghost commented Jul 7, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #25918

Providing web socket upgrade response status code and headers.

Author: greenEkatherine
Assignees: -
Labels:

area-System.Net

Milestone: 7.0.0

@ghost

ghost commented Jul 7, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Comment thread src/libraries/System.Net.WebSockets.Client/tests/ConnectTest.cs Outdated
Comment thread src/libraries/System.Net.WebSockets.Client/tests/ConnectTest.cs Outdated
Comment thread src/libraries/System.Net.WebSockets.Client/tests/ConnectTest.cs
Comment thread src/libraries/System.Net.WebSockets.Client/tests/ConnectTest.cs Outdated
Katya Sokolova and others added 3 commits July 11, 2022 16:23
Comment thread src/libraries/System.Net.WebSockets.Client/tests/ConnectTest.cs
…ockets/ClientWebSocket.cs

Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>

@CarnaViire CarnaViire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I think 😄)

…ockets/WebSocketHandle.Managed.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
Katya Sokolova and others added 2 commits July 12, 2022 22:17
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
@greenEkatherine greenEkatherine merged commit 1846c07 into dotnet:main Jul 12, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API Proposal] ClientWebSocket upgrade response details

4 participants