Remove Microsoft.Diagnostics.Tracing.EventSource.Redist

[noahfalk]

This package was used historically to distribute EventSource fixes out-of-band but
is no longer needed. This change removed the project and the ES_BUILD_STANDALONE +
FEATURE_MANAGED_ETW_CHANNELS ifdefs which were only defined when the project was building.

Fixes #71231

[ghost]

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This package was used historically to distribute EventSource fixes out-of-band but
is no longer needed. This change removed the project and the ES_BUILD_STANDALONE +
FEATURE_MANAGED_ETW_CHANNELS ifdefs which were only defined when the project was building.

Fixes #71231

Author:	noahfalk
Assignees:	-
Labels:	area-System.Diagnostics.Tracing
Milestone:	-

[noahfalk]

@brianrob @tarekgh - PTAL

[tarekgh]

Looks the changes causing a compat issue, maybe we need to keep this API in the implementation.

Build FAILED.

/__w/1/s/.packages/microsoft.dotnet.apicompat/7.0.0-beta.22327.2/build/Microsoft.DotNet.ApiCompat.targets(52,5): error : Compat issues with assembly System.Diagnostics.Tracing: [/__w/1/s/src/libraries/System.Diagnostics.Tracing/src/System.Diagnostics.Tracing.csproj]
/__w/1/s/.packages/microsoft.dotnet.apicompat/7.0.0-beta.22327.2/build/Microsoft.DotNet.ApiCompat.targets(52,5): error : MembersMustExist : Member 'public System.Diagnostics.Tracing.EventChannel System.Diagnostics.Tracing.EventAttribute.Channel.get()' does not exist in the implementation but it does exist in the contract. [/__w/1/s/src/libraries/System.Diagnostics.Tracing/src/System.Diagnostics.Tracing.csproj]
/__w/1/s/.packages/microsoft.dotnet.apicompat/7.0.0-beta.22327.2/build/Microsoft.DotNet.ApiCompat.targets(52,5): error : MembersMustExist : Member 'public void System.Diagnostics.Tracing.EventAttribute.Channel.set(System.Diagnostics.Tracing.EventChannel)' does not exist in the implementation but it does exist in the contract. [/__w/1/s/src/libraries/System.Diagnostics.Tracing/src/System.Diagnostics.Tracing.csproj]
/__w/1/s/.packages/microsoft.dotnet.apicompat/7.0.0-beta.22327.2/build/Microsoft.DotNet.ApiCompat.targets(52,5): error : MembersMustExist : Member 'public System.Diagnostics.Tracing.EventChannel System.Diagnostics.Tracing.EventWrittenEventArgs.Channel.get()' does not exist in the implementation but it does exist in the contract. [/__w/1/s/src/libraries/System.Diagnostics.Tracing/src/System.Diagnostics.Tracing.csproj]
/__w/1/s/.packages/microsoft.dotnet.apicompat/7.0.0-beta.22327.2/build/Microsoft.DotNet.ApiCompat.targets(66,5): error : ApiCompat failed for '/__w/1/s/artifacts/bin/System.Diagnostics.Tracing/Release/net7.0/System.Diagnostics.Tracing.dll' [/__w/1/s/src/libraries/System.Diagnostics.Tracing/src/System.Diagnostics.Tracing.csproj]
    0 Warning(s)
    5 Error(s)

[tarekgh]

CC @ericstj for awareness.

[ericstj]

CC @ericstj for awareness.

I am OK with the premise of this PR, but it needs to be done in a way that doesn't break the package/API we still ship.

[noahfalk]

I am OK with the premise of this PR, but it needs to be done in a way that doesn't break the package/API we still ship.

For sure. I think it was a mistake on the FEATURE_MANAGED_ETW_CHANNELS which was defined elsewhere and the local builds I had done didn't have the right configurations to spot it.

[ericstj]

You should be able to repro locally with a build of libs, then dotnet build of src/libraries/System.Diagnostics.Tracing/src/System.Diagnostics.Tracing.csproj which should build everything with minimal overhead.

[noahfalk]

Build failure is known issue: #71684

[noahfalk]

I think all the feedback has been addressed, does this look good now? Thanks!

[brianrob]

LGTM!

[noahfalk]

Thanks all! I'm merging on red but the issue shown by build analysis is a known one unrelated to this change: #71684