On 64 bit platforms, "stelem.ref" and "ldelema" ignore the high bits of a native int index#71571
Conversation
…of a native int index Fix dotnet#52817
ghost
added
the
AaronRobinsonMSFT
left a comment
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
Do we need to update Mono too?
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/CastHelpers.cs
Outdated
Show resolved
Hide resolved
|
We had the same problem for NewArray helper some time ago and we fixed it there by changing the NewArray helper to take native int. Would it be better to do the same thing here to avoid the code duplication? For R2R, we have introduced a new compat band in .NET 7, so it is ok to make JIT helper breaking changes without doing anything special about it. |
…gh bits of a native int index" This reverts commit 47eba9a.
|
|
||
| ref object rawData = ref Unsafe.As<byte, object>(ref Unsafe.As<RawArrayData>(array).Data); | ||
| return ref Unsafe.Add(ref rawData, index); | ||
| return ref Unsafe.Add(ref rawData, (int)index); |
There was a problem hiding this comment.
There is Unsafe.Add overload that takes IntPtr. It should not be necessary to cast the index to int here. It just going to add an extra unnecessary instruction.
There was a problem hiding this comment.
If the problem is that the "minimal runtime" does not compile without the cast, just add the necessary method to the minimal Unsafe used by the minimal runtime.
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
4 participants
Fixes #52817