Skip to content

[debugger] First draft of managed debugger on wasi#67272

Merged
thaystg merged 68 commits into
dotnet:mainfrom
thaystg:debug_wasi
Aug 12, 2022
Merged

[debugger] First draft of managed debugger on wasi#67272
thaystg merged 68 commits into
dotnet:mainfrom
thaystg:debug_wasi

Conversation

@thaystg

@thaystg thaystg commented Mar 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Screencast from 28-03-2022 20_26_16

Still waiting for this fix to make it work using official wastime:
bytecodealliance/wasmtime#3936
I fixed locally to implement the PR and test it.

Debugger.Break(), Breakpoints, Stepping, Locals, Expressions and CallStack are working correctly.

@ghost ghost added the area-Debugger-mono label Mar 28, 2022
@ghost ghost assigned thaystg Mar 28, 2022
@ghost

ghost commented Mar 28, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Screencast from 28-03-2022 20_26_16

Still waiting for this fix to make it work using official wastime:
bytecodealliance/wasmtime#3936
I fixed locally to implement the PR and test it.

Stepping is not working yet.
Debugger.Break(), Breakpoints, Locals, Expressions and CallStack are working correctly.

Author: thaystg
Assignees: thaystg
Labels:

area-Debugger-mono
Milestone: -

@thaystg thaystg changed the title [debugger] First draft of debug wasi [debugger] First draft of managed debugger on wasi Mar 28, 2022
@SteveSandersonMS

SteveSandersonMS commented Mar 29, 2022

Copy link
Copy Markdown
Member

This is awesome! Super glad to see this!

SteveSandersonMS
SteveSandersonMS reviewed Mar 29, 2022
View reviewed changes
Comment thread src/mono/wasi/mono-wasi-driver/driver.c
@thaystg

thaystg commented Mar 29, 2022

Copy link
Copy Markdown
Member Author

Screencast from 29-03-2022 13_43_16

viniciusjarina
viniciusjarina reviewed Mar 30, 2022
View reviewed changes
Comment thread src/mono/mono/component/mini-wasi-debugger.c Outdated
@sdeleuze sdeleuze mentioned this pull request Apr 11, 2022
Open
@ghost ghost added the no-recent-activity label Apr 15, 2022
@ghost

ghost commented Apr 15, 2022

Copy link
Copy Markdown

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ghost ghost added the no-recent-activity label May 2, 2022
@ghost

ghost commented May 2, 2022

Copy link
Copy Markdown

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

radical
radical reviewed Aug 8, 2022
View reviewed changes
Comment thread src/mono/mono/component/mini-wasi-debugger.c Outdated
radical
radical reviewed Aug 8, 2022
View reviewed changes
Comment thread src/mono/mono/component/mini-wasi-debugger.c
@thaystg thaystg requested a review from pavelsavara as a code owner August 8, 2022 21:15
@radical

radical commented Aug 8, 2022

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelines Bot commented Aug 8, 2022

Copy link
Copy Markdown
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@radical

radical commented Aug 8, 2022

Copy link
Copy Markdown
Member

/azp run runtime, runtime-staging,runtime-dev-innerloop,dotnet-linker-tests

@azure-pipelines

azure-pipelines Bot commented Aug 8, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 4 pipeline(s).

radical
radical approved these changes Aug 9, 2022
View reviewed changes

@radical radical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats, and excellent job!!

@radical

radical commented Aug 10, 2022

Copy link
Copy Markdown
Member

The wasm failure is known, and can be ignored.

@radical radical mentioned this pull request Aug 10, 2022
Closed
@radical

radical commented Aug 10, 2022

Copy link
Copy Markdown
Member

And the NativeAOT failure is #73698 .

@SteveSandersonMS

SteveSandersonMS commented Aug 12, 2022

Copy link
Copy Markdown
Member

Awesome, great job with this @thaystg!

@thaystg thaystg merged commit 3db2ebf into dotnet:main Aug 12, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2022
@pavelsavara pavelsavara added the os-wasi Related to WASI variant of arch-wasm label Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS left review comments

@radical radical radical approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@vargaz vargaz Awaiting requested review from vargaz

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@marek-safar marek-safar Awaiting requested review from marek-safar

@BrzVlad BrzVlad Awaiting requested review from BrzVlad BrzVlad is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

+1 more reviewer

@viniciusjarina viniciusjarina viniciusjarina left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@thaystg thaystg

Labels

arch-wasm WebAssembly architecture area-Debugger-mono os-wasi Related to WASI variant of arch-wasm

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@thaystg @SteveSandersonMS @lewing @radical @viniciusjarina @BrzVlad @pavelsavara