[mono] Add eglib_objects cmake object target for eglib#50186
Closed
lambdageek wants to merge 1 commit intodotnet:mainfrom
Closed
[mono] Add eglib_objects cmake object target for eglib#50186lambdageek wants to merge 1 commit intodotnet:mainfrom
lambdageek wants to merge 1 commit intodotnet:mainfrom
Conversation
lambdageek
requested review from
CoffeeFlux,
SamMonoRT and
vargaz
as code owners
ghost
added
the
Link it into monosgen-shared and monosgen-static. This is needed by the "mono components" prototype dotnet#49913 so that each dynamic component could statically link its own version of eglib operations (and we will do followup work to move the ones that use global state, like the logging operations, to be in monosgen-{shared,static} only)
lambdageek
force-pushed
the
cmake-eglib-object-library
branch
from
f7b4c40 to
d19b86e
Compare
Member
Author
|
/cc @lateralusX |
Member
Author
|
I think the main risk here is if someone sets properties or cflags on |
Member
Author
|
Subsumed by #50837 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link it into monosgen-shared and monosgen-static.
This is needed by the "mono components" prototype #49913 so that each dynamic component could statically link its own version of eglib operations (and we will do followup work to move the ones that use global state, like the logging operations, to be in monosgen-{shared,static} only)