Fix race condition in ReleaseOnDetach test#48747
Merged
Merged
Conversation
|
Tagging subscribers to this area: @tommcdon Issue DetailsFixes #47098 There was a race condition in the ReleaseOnDetachTest. The call from the managed testcase to request a profiler attach to itself will block until the profiler succeeds in attaching, then the profiler requests a detach instantly. The vast majority of the time it takes a bit for the detach to actually happen, but sometimes the detach could happen before the call to SetBoolPtr happens. Then SetBoolPtr would call in to the profiler after detach and potentially AV. The fix here is to add synchronization by polling for _doneFlag.
|
hoyosjs
approved these changes
Feb 25, 2021
sdmaclea
reviewed
Feb 25, 2021
sdmaclea
approved these changes
Feb 25, 2021
hoyosjs
reviewed
Feb 25, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47098
There was a race condition in the ReleaseOnDetachTest. The call from the managed testcase to request a profiler attach to itself will block until the profiler succeeds in attaching, then the profiler requests a detach instantly. The vast majority of the time it takes a bit for the detach to actually happen, but sometimes the detach could happen before the call to SetBoolPtr happens. Then SetBoolPtr would call in to the profiler after detach and potentially AV.
The fix here is to add synchronization by polling for _doneFlag.