Skip to content

Fix armel build#47771

Merged
davidwrighton merged 1 commit into
dotnet:masterfrom
gbalykov:fix-armel-build
Feb 5, 2021
Merged

Fix armel build#47771
davidwrighton merged 1 commit into
dotnet:masterfrom
gbalykov:fix-armel-build

Conversation

@gbalykov

@gbalykov gbalykov commented Feb 2, 2021

Copy link
Copy Markdown
Member

Build for armel fails after #47502 with:

/home/runtime/src/coreclr/tools/aot/crossgen2/crossgen2.csproj(114,5): error MSB3030: Could not copy the file "/home/runtime/artifacts/bin/coreclr/Linux.armel.Release/x64/libclrjit_unix_armel_x64.so" because it was not found.

This change is a cleanup for armel, since there was some inconsistency.

Before:

ARCH_HOST_NAME=armel
ARCH_TARGET_NAME=arm

After:

ARCH_HOST_NAME=armel
ARCH_TARGET_NAME=armel

cc @alpencolt

@gbalykov

gbalykov commented Feb 4, 2021

Copy link
Copy Markdown
Member Author

cc @jkotas

@jkotas

jkotas commented Feb 4, 2021

Copy link
Copy Markdown
Member

Looks like a follow up on #41126 . @davidwrighton Could you please take a look?

@jkotas jkotas requested a review from davidwrighton February 4, 2021 18:43

@davidwrighton davidwrighton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks good

@davidwrighton davidwrighton merged commit 9a283e1 into dotnet:master Feb 5, 2021
@gbalykov

gbalykov commented Feb 5, 2021

Copy link
Copy Markdown
Member Author

Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclr Only use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants