Skip to content

Add GetCiphertextLength for CBC, CFB, and ECB.#45003

Merged
bartonjs merged 2 commits into
dotnet:masterfrom
vcsjones:2406-ciphertext-length
Nov 21, 2020
Merged

Add GetCiphertextLength for CBC, CFB, and ECB.#45003
bartonjs merged 2 commits into
dotnet:masterfrom
vcsjones:2406-ciphertext-length

Conversation

@vcsjones

@vcsjones vcsjones commented Nov 20, 2020

Copy link
Copy Markdown
Member

Adds GetCiphertextLength public APIs.

Contributes to #2406

@Dotnet-GitSync-Bot

Dotnet-GitSync-Bot commented Nov 20, 2020

Copy link
Copy Markdown
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Nov 20, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds GetCiphertextLength public APIs.

Contributes to #2406

Author: vcsjones
Assignees: -
Labels:

area-System.Security, new-api-needs-documentation
Milestone: -

vcsjones
vcsjones commented Nov 20, 2020
View reviewed changes
Comment thread ...aries/System.Security.Cryptography.Primitives/ref/System.Security.Cryptography.Primitives.cs
Comment thread ...stem.Security.Cryptography.Primitives/src/System/Security/Cryptography/SymmetricAlgorithm.cs Outdated
@vcsjones
Respond to code review feedback.
314c00b 
* Too many empty lines.
* Change CryptographicException to InvalidOperationException.
* Add a remark that CFB accepts and valid feedback size, even if
    the underlying algorithm does not support that feedback size.
@EgorBo

EgorBo commented Nov 20, 2020

Copy link
Copy Markdown
Member

Speaking of new APIs, are there any plans to add an API to specify padding for AesGcm and AesCcm ?

@bartonjs

bartonjs commented Nov 20, 2020

Copy link
Copy Markdown
Member

are there any plans to add an API to specify padding for AesGcm and AesCcm?

No, because padding doesn't normally come up with those. Do you know of a case where it does?

@vcsjones

vcsjones commented Nov 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

@EgorBo

padding for AesGcm and AesCcm ?

GCM / CCM is stream-like, so it does not require padding. One bit in, one bit out.

Edit: Always 20 seconds too slow.

@runfoapp runfoapp Bot mentioned this pull request Nov 20, 2020
Open
@bartonjs
bartonjs merged commit 028cde2 into dotnet:master Nov 21, 2020
@vcsjones
vcsjones deleted the 2406-ciphertext-length branch November 21, 2020 00:57
@ghost ghost locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bartonjs bartonjs bartonjs approved these changes

Assignees

No one assigned

Labels

area-System.Security new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vcsjones @Dotnet-GitSync-Bot @EgorBo @bartonjs