Enable linker substitutions for more architectures.

[marek-safar]

No description provided.

[ghost]

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

[jkotas]

Thanks

[eerhardt]

  Value does not fall within the expected range.
F:\workspace\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.20459.8\tools\SymStore.targets(70,5): error MSB3073: The command ""F:\workspace\_work\1\s\.packages\microsoft.diasymreader.pdb2pdb\1.1.0-beta2-19575-01\tools\Pdb2Pdb.exe" "F:\workspace\_work\1\s\artifacts\bin\coreclr\Windows_NT.x64.Release\IL\System.Private.CoreLib.dll" /out "F:\workspace\_work\1\s\artifacts\SymStore\Release\System.Private.CoreLib\net5.0\x64\System.Private.CoreLib.pdb" /srcsvrvar SRC_INDEX=public" exited with code 2. [F:\workspace\_work\1\s\src\coreclr\src\System.Private.CoreLib\System.Private.CoreLib.csproj]

This looks like a new problem in the same area that we hit the last time we tried this.

cc @vitek-karas

[eerhardt]

This PR should resolve #31785

[jkotas]

This PR should resolve #31785

It will resolve it for CoreLib. Ideally, we would do this for everything in the shared framework.

[eerhardt]

Ideally, we would do this for everything in the shared framework.

That isn't possible without addressing the issues brought up in #31712. If we need to do this for everything in the shared framework, we should re-open #31712 and address the issues brought up there.

[vitek-karas]

The PDB2PDB failure needs investigation - I'll get to it eventually, but given this is 6.0 only, I have to prioritize 5.0 work still.

[vitek-karas]

I was finally able to get back to this - the problem doesn't repro locally if I use the latest mono/linker master build of linker - so maybe we just need to pick up the latest linker in the runtime repo.

[eerhardt]

so maybe we just need to pick up the latest linker in the runtime repo.

#43181 just brought in a new linker a few hours ago. Closing and re-opening this PR to re-run CI on the latest.

[eerhardt]

@vitek-karas - Looks like the CI is still failing even with the latest linker changes:

2020-10-09T19:11:52.2092988Z   Value does not fall within the expected range.
2020-10-09T19:11:52.2314176Z F:\workspace\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.20506.7\tools\SymStore.targets(70,5): error MSB3073: The command ""F:\workspace\_work\1\s\.packages\microsoft.diasymreader.pdb2pdb\1.1.0-beta2-19575-01\tools\Pdb2Pdb.exe" "F:\workspace\_work\1\s\artifacts\bin\mono\Windows_NT.x64.Release\IL\System.Private.CoreLib.dll" /out "F:\workspace\_work\1\s\artifacts\SymStore\Release\System.Private.CoreLib\net6.0\x64\System.Private.CoreLib.pdb" /srcsvrvar SRC_INDEX=public" exited with code 2. [F:\workspace\_work\1\s\src\mono\netcore\System.Private.CoreLib\System.Private.CoreLib.csproj]
2020-10-09T19:11:52.2433282Z ##[error].packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.20506.7\tools\SymStore.targets(70,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""F:\workspace\_work\1\s\.packages\microsoft.diasymreader.pdb2pdb\1.1.0-beta2-19575-01\tools\Pdb2Pdb.exe" "F:\workspace\_work\1\s\artifacts\bin\mono\Windows_NT.x64.Release\IL\System.Private.CoreLib.dll" /out "F:\workspace\_work\1\s\artifacts\SymStore\Release\System.Private.CoreLib\net6.0\x64\System.Private.CoreLib.pdb" /srcsvrvar SRC_INDEX=public" exited with code 2.
2020-10-09T19:11:52.2450431Z 
2020-10-09T19:11:52.2451041Z Build FAILED.

Using the binlog from the CI, I was able to verify that a recent build of the linker was used:

F:\workspace\_work\1\s\.dotnet\dotnet.exe "F:\workspace\_work\1\s\.packages\microsoft.net.illink.tasks\6.0.0-alpha.1.20509.3\tools\net5.0\illink.dll" -reference "F:\workspace\_work\1\s\artifacts\obj\coreclr\System.Private.CoreLib\x64\Release\PreTrim/System.Private.CoreLib.dll"
-out "F:\workspace\_work\1\s\artifacts\obj\coreclr\System.Private.CoreLib\x64\Release"
--warnaserror-  -t --strip-link-attributes false --ignore-link-attributes true --skip-unresolved true --disable-opt unusedinterfaces -r System.Private.CoreLib -c skip -u skip -p link System.Private.CoreLib -b true --strip-descriptors false --strip-substitutions false --keep-dep-attributes true --nowarn IL2008;IL2009;IL2012;IL2025;IL2026;IL2035;IL2050;IL2032;IL2055;IL2057;IL2058;IL2059;IL2060;IL2061;IL2062;IL2063;IL2064;IL2065;IL2066;IL2067;IL2068;IL2069;IL2070;IL2071;IL2072;IL2073;IL2074;IL2075;IL2076;IL2077;IL2078;IL2079;IL2080;IL2081;IL2082;IL2083;IL2084;IL2085;IL2086;IL2087;IL2088;IL2089;IL2090;IL2091