Update SYSLIB0012 obsoletion messages to be clear and consistent#41467
Merged
jeffhandley merged 1 commit intodotnet:masterfrom Aug 27, 2020
jeffhandley:assembly-obsoletion-messages
Merged
Update SYSLIB0012 obsoletion messages to be clear and consistent#41467jeffhandley merged 1 commit intodotnet:masterfrom jeffhandley:assembly-obsoletion-messages
jeffhandley merged 1 commit intodotnet:masterfrom
jeffhandley:assembly-obsoletion-messages
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
terrajobst
approved these changes
Aug 27, 2020
Member
Author
|
/backport to release/5.0 |
Contributor
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/227762640 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When directing people toward our list of obsoletions in 5.0, I realized the message for obsoleting
Assembly.CodeBaseandAssembly.EscapedCodeBasewas unclear without context. In consideration of updating the message, I also realized oursrcandrefassemblies were not consistent with each other on these messages either.This PR updates the message to give more context and it fixes the inconsistency. I recommend we fix this in 5.0.