Adding default string for stacktrace Word_At#38634
Merged
joperezr merged 3 commits intodotnet:masterfrom Jun 30, 2020
Merged
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
joperezr
commented
Jun 30, 2020
src/libraries/System.Private.CoreLib/src/System/Diagnostics/StackTrace.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Jun 30, 2020
eerhardt
approved these changes
Jun 30, 2020
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Looks good. Just a couple nits on the comments.
src/libraries/System.Private.CoreLib/src/System/Diagnostics/StackTrace.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Diagnostics/StackTrace.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on the discussion we had here: #38397 (comment) as @eerhardt did go and check and looks like StackTrace isn't using a default value for the word "at" in case resourceKeys are used.
I decided to send this out as a separate PR in order to not reset CI on the Resources PR which has finished and is ready to merge.