JIT: use new phase objects more extensively#32688
Merged
Merged
Conversation
Convert the mainline compiler phases over so they are run via compiler or action phases. To keep jit dump size and checked jit throughput the same as it is now, add phase whitelists to opt into pre phase dumps and checks triggered by the phase objects on a per-phase basis. This allow us to gradually remove explicit dumps and check invocations phase by phase, over time.
Member
Author
|
Contributes to #2109. Verified no diffs. @dotnet/jit-contrib PTAL |
AndyAyersMS
added
the
area-CodeGen-coreclr
12 tasks
BruceForstall
suggested changes
Feb 24, 2020
BruceForstall
left a comment
BruceForstall
left a comment
Contributor
There was a problem hiding this comment.
Seems like some of the larger auto clauses might be better extracted out as functions. But generally looks good to me (except the apparently incorrect #ifdefs.)
BruceForstall
approved these changes
Feb 24, 2020
Member
Author
|
@dotnet/jit-contrib anyone else want to look this over? I'm somewhat ambivalent about the lambdas, though we can always peel those out as named functions if they become too annoying. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the mainline compiler phases over so they are run via compiler or
action phases.
To keep jit dump size and checked jit throughput the same as it is now,
add phase whitelists to opt into pre phase dumps and checks triggered by the
phase objects on a per-phase basis. This allow us to gradually remove explicit
dumps and check invocations phase by phase, over time.