Nullable annotate System.Security.Cryptography.Cng#32039
Merged
eiriktsarpalis merged 7 commits intodotnet:masterfrom Feb 14, 2020
Merged
Conversation
eiriktsarpalis
added
the
NO-MERGE
Member
Author
|
I missed that annotation work for System.Security.Cryptography.Algorithms hasn't been merged yet (#2375). Holding off until that is done. |
eiriktsarpalis
force-pushed
the
annotate-system-security-cryptography-cng
branch
from
8448e1a to
726b318
Compare
eiriktsarpalis
removed
the
NO-MERGE
bartonjs
reviewed
Feb 11, 2020
src/libraries/Common/src/Internal/Cryptography/HashProviderCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Windows/BCrypt/BCryptAlgorithmCache.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Windows/BCrypt/BCryptAlgorithmCache.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Windows/BCrypt/Interop.BCryptOpenAlgorithmProvider.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Cng/src/System/Security/Cryptography/CngKey.EC.cs
Outdated
Show resolved
Hide resolved
...ystem.Security.Cryptography.Cng/src/System/Security/Cryptography/CngKeyCreationParameters.cs
Outdated
Show resolved
Hide resolved
...ystem.Security.Cryptography.Cng/src/System/Security/Cryptography/CngKeyCreationParameters.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
force-pushed
the
annotate-system-security-cryptography-cng
branch
from
4f71527 to
0ed07ab
Compare
Member
Author
|
This should be ready to go in. |
eiriktsarpalis
force-pushed
the
annotate-system-security-cryptography-cng
branch
from
0ed07ab to
b141ed3
Compare
eiriktsarpalis
force-pushed
the
annotate-system-security-cryptography-cng
branch
from
77037eb to
b141ed3
Compare
buyaa-n
reviewed
Feb 13, 2020
src/libraries/Common/src/Internal/Cryptography/HashProviderCng.cs
Outdated
Show resolved
Hide resolved
buyaa-n
reviewed
Feb 13, 2020
src/libraries/Common/src/Interop/Windows/BCrypt/BCryptAlgorithmCache.cs
Outdated
Show resolved
Hide resolved
buyaa-n
reviewed
Feb 13, 2020
src/libraries/Common/src/System/Security/Cryptography/Asn1/AlgorithmIdentifierAsn.manual.cs
Outdated
Show resolved
Hide resolved
buyaa-n
reviewed
Feb 13, 2020
src/libraries/Common/src/System/Security/Cryptography/ECCng.HashAlgorithm.cs
Outdated
Show resolved
Hide resolved
buyaa-n
reviewed
Feb 13, 2020
src/libraries/Common/src/System/Security/Cryptography/KeyFormatHelper.cs
Outdated
Show resolved
Hide resolved
buyaa-n
reviewed
Feb 13, 2020
...ies/System.Security.Cryptography.Cng/src/Internal/Cryptography/BasicSymmetricCipherNCrypt.cs
Outdated
Show resolved
Hide resolved
buyaa-n
reviewed
Feb 13, 2020
...libraries/System.Security.Cryptography.Cng/src/System/Security/Cryptography/CngKey.Export.cs
Outdated
Show resolved
Hide resolved
buyaa-n
reviewed
Feb 13, 2020
.../System.Security.Cryptography.Cng/src/System/Security/Cryptography/ECDiffieHellmanCng.Key.cs
Outdated
Show resolved
Hide resolved
buyaa-n
reviewed
Feb 14, 2020
src/libraries/System.Security.Cryptography.Cng/src/System/Security/Cryptography/ECDsaCng.Key.cs
Outdated
Show resolved
Hide resolved
buyaa-n
approved these changes
Feb 14, 2020
Contributor
buyaa-n
left a comment
buyaa-n
left a comment
There was a problem hiding this comment.
Left few NIT comments, overall LGTM
eiriktsarpalis
force-pushed
the
annotate-system-security-cryptography-cng
branch
from
a67731c to
887f164
Compare
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #2339