Skip to content

Allow null IV for Create{Encryptor,Decryptor}.#31634

Merged
bartonjs merged 1 commit intodotnet:masterfrom
vcsjones:31631-null-iv
Feb 4, 2020
Merged

Allow null IV for Create{Encryptor,Decryptor}.#31634
bartonjs merged 1 commit intodotnet:masterfrom
vcsjones:31631-null-iv

Conversation

@vcsjones
Copy link
Copy Markdown
Member

@vcsjones vcsjones commented Feb 2, 2020

The IV is permitted to be null for most ciphers when in ECB mode.

The derived types are not yet done, or are in-progress at #2375.

Fixes #31631

@bartonjs @buyaa-n.

The IV is permitted to be null for most ciphers when in ECB
mode.
@buyaa-n buyaa-n added this to the 5.0 milestone Feb 3, 2020
@buyaa-n
Copy link
Copy Markdown
Contributor

buyaa-n commented Feb 3, 2020

Thank you @vcsjones for fixing it

@vcsjones
Copy link
Copy Markdown
Member Author

vcsjones commented Feb 3, 2020

Trying to parse the failures here...

  1. The S.S.C.Algorithms failures appear to be System.Security.Cryptography.OpenSsl.Tests failing on CI runs #2176.
  2. S.S.C.OpenSsl don't appear to have console output? (BlobDoesNotExist)
  3. A bunch of things failed in System.ComponentModel.TypeConverter.Tests which is perplexing. They appear unrelated from these changes. I could an issue for these failures?

@buyaa-n
Copy link
Copy Markdown
Contributor

buyaa-n commented Feb 3, 2020

They appear unrelated from these changes. I could an issue for these failures?

Agree, it not seems related to the PR, but I don't think we need issue for failures, it actually might alreaady fixed

@buyaa-n
Copy link
Copy Markdown
Contributor

buyaa-n commented Feb 3, 2020

/azp run runtime-libraries

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

@buyaa-n
Copy link
Copy Markdown
Contributor

buyaa-n commented Feb 3, 2020

/azp run runtime

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@vcsjones
Copy link
Copy Markdown
Member Author

vcsjones commented Feb 4, 2020

Looks like #2389 this time.

@bartonjs
Copy link
Copy Markdown
Member

bartonjs commented Feb 4, 2020

Seems unrelated, gonna go ahead and merge this metadata-only change.

@bartonjs bartonjs merged commit c580502 into dotnet:master Feb 4, 2020
@vcsjones vcsjones deleted the 31631-null-iv branch February 4, 2020 04:05
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rbgIV should be nullable for CreateEncryptor / CreateDecryptor

5 participants