[Wasm RyuJIT] Fix: Use passed in ig when possible for IF_CODE_SIZE in emitDispIns()#128172
Merged
AndyAyersMS merged 1 commit intoMay 15, 2026
Merged
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
There was a problem hiding this comment.
Pull request overview
This change updates the Wasm JIT disassembly path to compute IF_CODE_SIZE using the instruction group passed into emitDispIns() when available, instead of unconditionally relying on emitCurIG. This makes emitDispIns() more robust in scenarios where it is invoked outside the normal codegen emission flow (where emitCurIG may not be set).
Changes:
- In
emitDispIns()forIF_CODE_SIZE, prefer the passedigparameter and fall back toemitCurIGonly if needed. - Add assertions to enforce the expected invariant that an instruction group is available before using it to resolve the current function.
AndyAyersMS
reviewed
May 14, 2026
AndyAyersMS
approved these changes
May 14, 2026
Contributor
Author
|
/ba-g unrelated infra failures |
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't always rely on
emitCurIGbeing set sinceemitDispInscan be called after codegen, so use the current passed in ig when possible in forIF_CODE_SIZEinemitDispInsfor Wasm.